RESOLVED FIXED 95643
[Gtk] accessibility/replaced-objects-in-anonymous-blocks layout test failure
https://bugs.webkit.org/show_bug.cgi?id=95643
Summary [Gtk] accessibility/replaced-objects-in-anonymous-blocks layout test failure
Joanmarie Diggs
Reported 2012-09-01 06:24:46 PDT
As part of the fix for 72811, a test which needed to be updated was updated by Zan. (Thanks!) One more tweak needs to be made. Now that my build has finished, I am seeing: --- /home/jd/checkout/WebKit/WebKitBuild/Release/layout-test-results/platform/gtk/accessibility/replaced-objects-in-anonymous-blocks-expected.txt +++ /home/jd/checkout/WebKit/WebKitBuild/Release/layout-test-results/platform/gtk/accessibility/replaced-objects-in-anonymous-blocks-actual.txt @@ -19,7 +19,8 @@ AXRole: document frame AXRole: panel AXValue: <obj>text area<\n> AXRole: entry AXValue: text area - AXRole: push button + AXRole: section AXValue: Div<\n><obj>button + AXRole: push button AXRole: heading AXValue: Heading<\n><obj>button<\n><obj> The push button is inside a div and the div has additional content, so one would expect the div to be in the accessible hierarchy. And in gtk a11y, div == section. Thus the above seems correct. The question is, why didn't the bot where the test originally failed see that? I'll attach a patch and leave it to the gardeners to sort out the bots. :)
Attachments
Patch (1.60 KB, patch)
2012-09-01 06:29 PDT, Joanmarie Diggs
no flags
Patch (1.64 KB, patch)
2012-09-01 08:40 PDT, Joanmarie Diggs
no flags
Joanmarie Diggs
Comment 1 2012-09-01 06:29:06 PDT
Joanmarie Diggs
Comment 2 2012-09-01 08:40:53 PDT
WebKit Review Bot
Comment 3 2012-09-01 11:15:57 PDT
Comment on attachment 161829 [details] Patch Clearing flags on attachment: 161829 Committed r127377: <http://trac.webkit.org/changeset/127377>
WebKit Review Bot
Comment 4 2012-09-01 11:16:00 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.