RESOLVED FIXED 87719
REGRESSION(r111497): The "option" element doesn't match CSS pseudo class :enabled 
https://bugs.webkit.org/show_bug.cgi?id=87719
Summary REGRESSION(r111497): The "option" element doesn't match CSS pseudo class :ena...
yosin
Reported 2012-05-29 03:01:37 PDT
In SelectorChecker::checkOneSelector, following code fragment should check element->hasTagName(optionTag). Because, r111497 changed base class of HTMLOptionElement to HTMLElement from HTMLFormControlElement. case CSSSelector::PseudoEnabled: if (element && element->isFormControlElement()) return element->isEnabledFormControl(); break;
Attachments
Patch 1 (25.21 KB, patch)
2012-05-29 18:51 PDT, yosin 		no flags
DetailsFormatted DiffDiff
Patch 2 (25.21 KB, patch)
2012-05-29 19:16 PDT, yosin 		no flags
DetailsFormatted DiffDiff
Patch 3 (25.21 KB, patch)
2012-05-29 21:08 PDT, yosin 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
yosin
Comment 1 2012-05-29 18:51:34 PDT
Created attachment 144673 [details] Patch 1
yosin
Comment 2 2012-05-29 18:52:15 PDT
Comment on attachment 144673 [details] Patch 1 Could you review this patch? Thanks in advance.
Kent Tamura
Comment 3 2012-05-29 18:55:54 PDT
Comment on attachment 144673 [details] Patch 1 View in context: https://bugs.webkit.org/attachment.cgi?id=144673&action=review > Source/WebCore/css/SelectorChecker.cpp:1054 > - if (element && (element->isFormControlElement() || element->hasTagName(optgroupTag))) > + if (element && (element->isFormControlElement() || element->hasTagName(optionTag) || element->hasTagName(optgroupTag))) Would you remove one space after the second || please?
mitz
Comment 4 2012-05-29 18:57:27 PDT
<rdar://problem/11553964>
yosin
Comment 5 2012-05-29 19:16:08 PDT
Created attachment 144677 [details] Patch 2
yosin
Comment 6 2012-05-29 19:16:38 PDT
Comment on attachment 144677 [details] Patch 2 Remove an extra space.
WebKit Review Bot
Comment 7 2012-05-29 21:05:14 PDT
Comment on attachment 144677 [details] Patch 2 Rejecting attachment 144677 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 ERROR: /mnt/git/webkit-commit-queue/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/12845746
yosin
Comment 8 2012-05-29 21:08:37 PDT
Created attachment 144690 [details] Patch 3
WebKit Review Bot
Comment 9 2012-05-29 21:34:49 PDT
Comment on attachment 144690 [details] Patch 3 Clearing flags on attachment: 144690 Committed r118891: <http://trac.webkit.org/changeset/118891>
WebKit Review Bot
Comment 10 2012-05-29 21:34:58 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.