RESOLVED FIXED 65967
WebSocket: Add binaryType attribute 
https://bugs.webkit.org/show_bug.cgi?id=65967
Summary WebSocket: Add binaryType attribute
Yuta Kitamura
Reported 2011-08-10 00:30:37 PDT
WebSocket API defines a new attribute "binaryType" which controls the data type of MessageEvent.data for binary frames. http://dev.w3.org/html5/websockets/#the-websocket-interface
Attachments
Patch (9.06 KB, patch)
2011-08-10 00:51 PDT, Yuta Kitamura 		no flags
DetailsFormatted DiffDiff
Patch for landing (9.06 KB, patch)
2011-08-10 01:45 PDT, Yuta Kitamura 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yuta Kitamura
Comment 1 2011-08-10 00:51:47 PDT
Created attachment 103449 [details] Patch
Kent Tamura
Comment 2 2011-08-10 01:04:43 PDT
Comment on attachment 103449 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=103449&action=review > Source/WebCore/websockets/WebSocket.cpp:223 > + if (m_binaryType == BinaryTypeBlob) > + return "blob"; > + if (m_binaryType == BinaryTypeArrayBuffer) > + return "arraybuffer"; We had better use switch-case.
Yuta Kitamura
Comment 3 2011-08-10 01:45:17 PDT
Created attachment 103452 [details] Patch for landing
WebKit Review Bot
Comment 4 2011-08-10 02:20:04 PDT
Comment on attachment 103452 [details] Patch for landing Clearing flags on attachment: 103452 Committed r92759: <http://trac.webkit.org/changeset/92759>
WebKit Review Bot
Comment 5 2011-08-10 02:20:09 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.