RESOLVED FIXED 39833
Web Inspector: Implement retrieval of CSS stylesheets for source editing 
https://bugs.webkit.org/show_bug.cgi?id=39833
Summary Web Inspector: Implement retrieval of CSS stylesheets for source editing
Alexander Pavlov (apavlov)
Reported 2010-05-27 06:16:22 PDT
Web Inspector needs stylesheets with source ranges of rule bodies to implement CSS editing
Attachments
[PATCH] Suggested solution (32.83 KB, patch)
2010-05-28 06:26 PDT, Alexander Pavlov (apavlov) 		no flags
DetailsFormatted DiffDiff
[PATCH] Altered patch as discussed offline with pfeldman (29.96 KB, patch)
2010-05-31 06:27 PDT, Alexander Pavlov (apavlov) 		pfeldman: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alexander Pavlov (apavlov)
Comment 1 2010-05-28 06:26:49 PDT
Created attachment 57322 [details] [PATCH] Suggested solution
Alexander Pavlov (apavlov)
Comment 2 2010-05-31 06:27:01 PDT
Created attachment 57458 [details] [PATCH] Altered patch as discussed offline with pfeldman Introduced explicit retrieval of rule ranges instead of adding them to the rules in the styleSheet.cssRules property
Pavel Feldman
Comment 3 2010-05-31 07:55:36 PDT
Comment on attachment 57458 [details] [PATCH] Altered patch as discussed offline with pfeldman WebCore/css/CSSParser.cpp:234 + void CSSParser::parseSheet(CSSStyleSheet* sheet, const String& string, HashMap<CSSStyleRule*, std::pair<unsigned, unsigned> >* ruleRangeMap) You might want to introduce a typedef for this. Something like StyleRulePositions.
Alexander Pavlov (apavlov)
Comment 4 2010-05-31 09:48:05 PDT
Landed with the suggested typedef Committing to http://svn.webkit.org/repository/webkit/trunk ... M LayoutTests/ChangeLog A LayoutTests/inspector/styles-source-offsets-expected.txt A LayoutTests/inspector/styles-source-offsets.html M WebCore/ChangeLog M WebCore/css/CSSParser.cpp M WebCore/css/CSSParser.h M WebCore/inspector/InspectorBackend.cpp M WebCore/inspector/InspectorBackend.h M WebCore/inspector/InspectorBackend.idl M WebCore/inspector/InspectorCSSStore.cpp M WebCore/inspector/InspectorCSSStore.h M WebCore/inspector/InspectorDOMAgent.cpp M WebCore/inspector/InspectorDOMAgent.h M WebCore/inspector/InspectorFrontend.cpp M WebCore/inspector/InspectorFrontend.h M WebCore/inspector/front-end/DOMAgent.js Committed r60443
Note You need to log in before you can comment on or make changes to this bug.