RESOLVED FIXED 255021
Remove Quirk shouldDisableElementFullscreenQuirk for nfl.com 
https://bugs.webkit.org/show_bug.cgi?id=255021
Summary Remove Quirk shouldDisableElementFullscreenQuirk for nfl.com
Karl Dubost
Reported 2023-04-05 00:53:37 PDT
It's about removing shouldDisableElementFullscreenQuirk 1. With an iPad (large format, not a mini) 2. Go to https://nfl.com/ 3. Remote Inspect the iPad from the desktop 4. Disable Site Specific Hacks 5. Reload the https://nfl.com/ page 6. Play a video 7. Tap the fullscreen button Expected: Video goes fullscreen and the video controls are displayed. The Quirk had been put in place because the video had no controls. https://github.com/WebKit/WebKit/blob/f37c05e1232e7be8dca7ddebe2003a9b1d75948c/Source/WebCore/page/Quirks.cpp#L968-L986
Attachments
Add attachment proposed patch, testcase, etc.
Karl Dubost
Comment 1 2023-04-05 00:54:24 PDT
rdar://107633365
Karl Dubost
Comment 2 2023-04-09 21:54:15 PDT
Thanks to Zohreh Momeni for testing. We can remove it.
Karl Dubost
Comment 3 2023-04-09 21:57:48 PDT
Pull request: https://github.com/WebKit/WebKit/pull/12560
Karl Dubost
Comment 4 2023-04-10 15:48:27 PDT
Hmm retested today on iPadOS 16.4 And it seems we can't remove it. I will close the PR for now.
EWS
Comment 5 2023-08-10 02:01:07 PDT
Committed 266757@main (c8e45de869f8): <https://commits.webkit.org/266757@main> Reviewed commits have been landed. Closing PR #12560 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.