<rdar://problem/58606666>

--- /Volumes/Data/slave/catalina-release-tests-wk2/build/layout-test-results/storage/websql/statement-error-callback-expected.txt +++ /Volumes/Data/slave/catalina-release-tests-wk2/build/layout-test-results/storage/websql/statement-error-callback-actual.txt @@ -1,15 +1,7 @@ CONSOLE MESSAGE: line 64: Web SQL is deprecated. Please use IndexedDB instead. CONSOLE MESSAGE: line 67: Exception in statement error callback -This test confirms that a transaction is immediately rolled back if and only if a statement's error callback throws an exception, returns true, or doesn't return any value. -PASS - the transaction error callback was invoked. -PASS - the transaction error callback was invoked. -PASS - the transaction error callback was invoked. -PASS - the transaction error callback was invoked. -PASS - the transaction error callback was invoked. -PASS - the transaction error callback was invoked. -PASS - the transaction success callback was invoked. -PASS - the transaction success callback was invoked. -PASS - the transaction success callback was invoked. -PASS - the transaction success callback was invoked. -Test Complete +#PID UNRESPONSIVE - WebKitTestRunner (pid 31795) +FAIL: Timed out waiting for notifyDone to be called +#EOF +#EOF

This is not reproducing locally for me with iterations

I linked the wrong history. Correct History: https://results.webkit.org/?suite=layout-tests&test=storage%2Fwebsql%2Fstatement-error-callback.html

Marked this as timing out while investigating in: https://trac.webkit.org/changeset/254573/webkit

For this test, the history clearly points to r252064.

Created attachment 389057 [details] Patch

Created attachment 389064 [details] Patch

Comment on attachment 389064 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=389064&action=review > Source/WebCore/ChangeLog:10 > + task was the source of the flaky timeouts & crashes. Queueing this event loop task in & crashes?

Comment on attachment 389064 [details] Patch r=me

(In reply to Alexey Proskuryakov from comment #9) > Comment on attachment 389064 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=389064&action=review > > > Source/WebCore/ChangeLog:10 > > + task was the source of the flaky timeouts & crashes. Queueing this event loop task in > > & crashes? Yes, locally I saw flaky crashes.

Comment on attachment 389064 [details] Patch Clearing flags on attachment: 389064 Committed r255329: <https://trac.webkit.org/changeset/255329>

All reviewed patches have been landed. Closing bug.

This issue is still occurring according to history. https://results.webkit.org/?suite=layout-tests&suite=layout-tests&test=inspector%2Fcanvas%2FresolveContext-webgpu.html&test=storage%2Fwebsql%2Fstatement-error-callback.html

(In reply to Truitt Savell from comment #14) > This issue is still occurring according to history. > > https://results.webkit.org/?suite=layout-tests&suite=layout- > tests&test=inspector%2Fcanvas%2FresolveContext-webgpu. > html&test=storage%2Fwebsql%2Fstatement-error-callback.html :( It was no longer reproducing locally even though it was easily reproducible on my machine before the fix. I guess I may have made it less flaky but it is still flaky. Anyway, I will investigate further.

(In reply to Chris Dumez from comment #15) > (In reply to Truitt Savell from comment #14) > > This issue is still occurring according to history. > > > > https://results.webkit.org/?suite=layout-tests&suite=layout- > > tests&test=inspector%2Fcanvas%2FresolveContext-webgpu. > > html&test=storage%2Fwebsql%2Fstatement-error-callback.html > > :( It was no longer reproducing locally even though it was easily > reproducible on my machine before the fix. I guess I may have made it less > flaky but it is still flaky. Anyway, I will investigate further. I am trying various things but I can no longer reproduce the flakiness locally after my change..

Committed r255431: <https://trac.webkit.org/changeset/255431>