RESOLVED WORKSFORME 202264
[Pointer Events] iOS build error with Xcode 11 
https://bugs.webkit.org/show_bug.cgi?id=202264
Summary [Pointer Events] iOS build error with Xcode 11
Frédéric Wang (:fredw)
Reported 2019-09-26 02:56:00 PDT
It seems there are errors related to undefined CSS properties inside #ifdef POINTER_EVENTS. I wonder whether that's related to bug 199562
Attachments
Workaround patch (10.63 KB, patch)
2019-09-26 05:34 PDT, Frédéric Wang (:fredw) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Frédéric Wang (:fredw)
Comment 1 2019-09-26 03:01:35 PDT
In file included from ./editing/ios/EditorIOS.mm:32: /Users/fred/WebKit/Source/WebCore/css/CSSPrimitiveValueMappings.h:5264:27: error: use of undeclared identifier 'CSSValueManipulation'; did you mean 'CSSValueSaturation'? m_value.valueID = CSSValueManipulation; ^~~~~~~~~~~~~~~~~~~~ CSSValueSaturation In file included from /Users/fred/WebKit/WebKitBuild/Debug-iphonesimulator/DerivedSources/WebCore/unified-sources/UnifiedSource9-mm.mm:1: In file included from ./editing/cocoa/WebContentReaderCocoa.mm:32: In file included from /Users/fred/WebKit/Source/WebCore/loader/cache/CachedResourceLoader.h:31: In file included from /Users/fred/WebKit/Source/WebCore/loader/cache/CachedResourceRequest.h:29: In file included from /Users/fred/WebKit/Source/WebCore/dom/Element.h:28: In file included from /Users/fred/WebKit/Source/WebCore/dom/Document.h:55: In file included from /Users/fred/WebKit/Source/WebCore/css/StyleColor.h:34: /Users/fred/WebKit/WebKitBuild/Debug-iphonesimulator/DerivedSources/WebCore/CSSValueKeywords.h:720:5: note: 'CSSValueSaturation' declared here CSSValueSaturation = 709, ^ In file included from /Users/fred/WebKit/WebKitBuild/Debug-iphonesimulator/DerivedSources/WebCore/unified-sources/UnifiedSource9-mm.mm:2: In file included from ./editing/ios/EditorIOS.mm:32: /Users/fred/WebKit/Source/WebCore/css/CSSPrimitiveValueMappings.h:5270:27: error: use of undeclared identifier 'CSSValuePanX' m_value.valueID = CSSValuePanX; ^ /Users/fred/WebKit/Source/WebCore/css/CSSPrimitiveValueMappings.h:5273:27: error: use of undeclared identifier 'CSSValuePanY' m_value.valueID = CSSValuePanY; ^ /Users/fred/WebKit/Source/WebCore/css/CSSPrimitiveValueMappings.h:5276:27: error: use of undeclared identifier 'CSSValuePinchZoom' m_value.valueID = CSSValuePinchZoom; ^ /Users/fred/WebKit/Source/WebCore/css/CSSPrimitiveValueMappings.h:5287:10: error: use of undeclared identifier 'CSSValueManipulation'; did you mean 'CSSValueSaturation'? case CSSValueManipulation: ^~~~~~~~~~~~~~~~~~~~ CSSValueSaturation In file included from /Users/fred/WebKit/WebKitBuild/Debug-iphonesimulator/DerivedSources/WebCore/unified-sources/UnifiedSource9-mm.mm:1: In file included from ./editing/cocoa/WebContentReaderCocoa.mm:32: In file included from /Users/fred/WebKit/Source/WebCore/loader/cache/CachedResourceLoader.h:31: In file included from /Users/fred/WebKit/Source/WebCore/loader/cache/CachedResourceRequest.h:29: In file included from /Users/fred/WebKit/Source/WebCore/dom/Element.h:28: In file included from /Users/fred/WebKit/Source/WebCore/dom/Document.h:55: In file included from /Users/fred/WebKit/Source/WebCore/css/StyleColor.h:34: /Users/fred/WebKit/WebKitBuild/Debug-iphonesimulator/DerivedSources/WebCore/CSSValueKeywords.h:720:5: note: 'CSSValueSaturation' declared here CSSValueSaturation = 709, ^ In file included from /Users/fred/WebKit/WebKitBuild/Debug-iphonesimulator/DerivedSources/WebCore/unified-sources/UnifiedSource9-mm.mm:2: In file included from ./editing/ios/EditorIOS.mm:32: /Users/fred/WebKit/Source/WebCore/css/CSSPrimitiveValueMappings.h:5291:10: error: use of undeclared identifier 'CSSValuePanX' case CSSValuePanX: ^ /Users/fred/WebKit/Source/WebCore/css/CSSPrimitiveValueMappings.h:5293:10: error: use of undeclared identifier 'CSSValuePanY' case CSSValuePanY: ^ /Users/fred/WebKit/Source/WebCore/css/CSSPrimitiveValueMappings.h:5295:10: error: use of undeclared identifier 'CSSValuePinchZoom' case CSSValuePinchZoom: ^ 8 errors generated.
Radar WebKit Bug Importer
Comment 2 2019-09-26 03:23:58 PDT
<rdar://problem/55738089>
Frédéric Wang (:fredw)
Comment 3 2019-09-26 05:34:21 PDT
Created attachment 379634 [details] Workaround patch This is just a silly patch reverting r247205 in order to make iOS build again.
Jonathan Bedard
Comment 4 2019-09-26 07:23:10 PDT
We're building iOS 13 on the bots now, is this still an issue?
Frédéric Wang (:fredw)
Comment 5 2019-09-26 07:56:04 PDT
(In reply to Jonathan Bedard from comment #4) > We're building iOS 13 on the bots now, is this still an issue? Ali mentioned he does not have the issue on bug 200477 comment 9. I'll try again with a fresh build soon.
Frédéric Wang (:fredw)
Comment 6 2019-09-26 13:16:57 PDT
Seems to to work after clearing the build dir and rebuilding.
Note You need to log in before you can comment on or make changes to this bug.