RESOLVED FIXED 189210
[WHLSL] Allow uniform buffers to be used in the interpreter 
https://bugs.webkit.org/show_bug.cgi?id=189210
Summary [WHLSL] Allow uniform buffers to be used in the interpreter
Myles C. Maxfield
Reported 2018-08-31 14:20:18 PDT
...
Attachments
Buffers already work (6.50 KB, patch)
2018-09-24 02:16 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
WIP (16.10 KB, patch)
2018-09-24 20:23 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (13.74 KB, patch)
2018-09-25 15:00 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Depends on pointer equality (165.63 KB, patch)
2018-09-25 22:37 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-09-12 18:50:25 PDT
<rdar://problem/44402996>
Myles C. Maxfield
Comment 2 2018-09-22 04:03:15 PDT
We also have to figure out how to do things like device atomic_uint[] x : register(u0); InterlockedAdd(&x[0], 1, null);
Myles C. Maxfield
Comment 3 2018-09-22 16:52:12 PDT
*** Bug 177093 has been marked as a duplicate of this bug. ***
Myles C. Maxfield
Comment 4 2018-09-24 02:16:20 PDT
Created attachment 350627 [details] Buffers already work
Myles C. Maxfield
Comment 5 2018-09-24 02:17:43 PDT
The only things remaining are just to make sure you can't write to the constant address space, and make sure pointers the standard library functions work with all the appropriate address spaces.
Myles C. Maxfield
Comment 6 2018-09-24 02:18:15 PDT
Comment on attachment 350627 [details] Buffers already work View in context: https://bugs.webkit.org/attachment.cgi?id=350627&action=review > Tools/WebGPUShadingLanguageRI/Test.js:809 > +tests.threadArrayLoad = function() Poorly named
Myles C. Maxfield
Comment 7 2018-09-24 20:23:42 PDT
Created attachment 350731 [details] WIP
Myles C. Maxfield
Comment 8 2018-09-25 15:00:22 PDT
Created attachment 350796 [details] Patch
Myles C. Maxfield
Comment 9 2018-09-25 22:37:48 PDT
Created attachment 350849 [details] Depends on pointer equality
WebKit Commit Bot
Comment 10 2018-09-28 19:28:05 PDT
Comment on attachment 350849 [details] Depends on pointer equality Clearing flags on attachment: 350849 Committed r236635: <https://trac.webkit.org/changeset/236635>
WebKit Commit Bot
Comment 11 2018-09-28 19:28:06 PDT
All reviewed patches have been landed. Closing bug.
Myles C. Maxfield
Comment 12 2018-09-28 23:55:17 PDT
Committed r236639: <https://trac.webkit.org/changeset/236639>
Myles C. Maxfield
Comment 13 2018-10-13 15:02:27 PDT
Migrated to https://github.com/gpuweb/WHLSL/issues/46
Note You need to log in before you can comment on or make changes to this bug.