RESOLVED MOVED 188517
[WHLSL] Verify the parser uses the same grammar as the language 
https://bugs.webkit.org/show_bug.cgi?id=188517
Summary [WHLSL] Verify the parser uses the same grammar as the language
Thomas Denney
Reported 2018-08-13 08:50:45 PDT
The current hand-written recursive-descent parser is relatively slow and is the main bottleneck of the `prepare` function. The parser should be rewritten using a tool that produces more efficient code, such as https://github.com/antlr/antlr4.
Attachments
Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2018-08-27 15:21:28 PDT
*** Bug 189014 has been marked as a duplicate of this bug. ***
Myles C. Maxfield
Comment 2 2018-08-27 15:22:11 PDT
It takes 2.5 hours to compile the standard library. 95% of the time is spent parsing.
Myles C. Maxfield
Comment 3 2018-08-28 15:55:01 PDT
One way to do this is by using a parser generator. Another way of doing this is with testing. Another way is via inspection.
Radar WebKit Bug Importer
Comment 4 2018-09-12 18:51:31 PDT
<rdar://problem/44403020>
Myles C. Maxfield
Comment 5 2018-10-13 15:35:46 PDT
Migrated to https://github.com/gpuweb/WHLSL/issues/101
Note You need to log in before you can comment on or make changes to this bug.