WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
123476
Add bindings code for crypto algorithm dictionaries
https://bugs.webkit.org/show_bug.cgi?id=123476
Summary
Add bindings code for crypto algorithm dictionaries
Alexey Proskuryakov
Reported
2013-10-29 15:49:50 PDT
We need to convert Algorithm dictionaries to C++ structs/classes, so that we could pass them to DOM code. This is somewhat complicated due to incompatibilities between Web IDL and WebCrypto (e.g. WebCrypto uses nested dictionaries, which is not allowed, and it also doesn't describe what exactly to do with missing dictionary elements).
Attachments
proposed patch
(40.83 KB, patch)
2013-10-29 16:07 PDT
,
Alexey Proskuryakov
sam
: review+
buildbot
: commit-queue-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1
2013-10-29 16:07:53 PDT
Created
attachment 215440
[details]
proposed patch Will fail to compile, because it depends on other patches. But the code is all disabled anyway, so EWS is not of much use.
Build Bot
Comment 2
2013-10-29 16:10:50 PDT
Comment on
attachment 215440
[details]
proposed patch
Attachment 215440
[details]
did not pass mac-wk2-ews (mac-wk2): Output:
http://webkit-queues.appspot.com/results/17148147
Alexey Proskuryakov
Comment 3
2013-10-31 10:31:31 PDT
Committed <
http://trac.webkit.org/r158366
>.
Alexey Proskuryakov
Comment 4
2013-10-31 10:38:26 PDT
Follow-up in <
http://trac.webkit.org/r158367
>.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug