Bug 255021
| Summary: | Remove Quirk shouldDisableElementFullscreenQuirk for nfl.com | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Karl Dubost <karlcow> |
| Component: | Media | Assignee: | Karl Dubost <karlcow> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| URL: | https://nfl.com/ | ||
| Bug Depends on: | 207020 | ||
| Bug Blocks: | |||
Karl Dubost
It's about removing shouldDisableElementFullscreenQuirk
1. With an iPad (large format, not a mini)
2. Go to https://nfl.com/
3. Remote Inspect the iPad from the desktop
4. Disable Site Specific Hacks
5. Reload the https://nfl.com/ page
6. Play a video
7. Tap the fullscreen button
Expected:
Video goes fullscreen and the video controls are displayed.
The Quirk had been put in place because the video had no controls.
https://github.com/WebKit/WebKit/blob/f37c05e1232e7be8dca7ddebe2003a9b1d75948c/Source/WebCore/page/Quirks.cpp#L968-L986
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Karl Dubost
rdar://107633365
Karl Dubost
Thanks to Zohreh Momeni for testing. We can remove it.
Karl Dubost
Pull request: https://github.com/WebKit/WebKit/pull/12560
Karl Dubost
Hmm retested today on iPadOS 16.4 And it seems we can't remove it.
I will close the PR for now.
EWS
Committed 266757@main (c8e45de869f8): <https://commits.webkit.org/266757@main>
Reviewed commits have been landed. Closing PR #12560 and removing active labels.