Bug 189210

Summary:

[WHLSL] Allow uniform buffers to be used in the interpreter

Product:

WebKit

Reporter:

Myles C. Maxfield <mmaxfield>

Component:

WebGPU

Assignee:

Myles C. Maxfield <mmaxfield>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, dino, fpizlo, jonlee, rmorisset, tdenney, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=177093

Bug Depends on:

189986

Bug Blocks:

176199, 189202

Attachments:

Description	Flags
Buffers already work	none
WIP	none
Patch	none
Depends on pointer equality	none

Myles C. Maxfield

Reported 2018-08-31 14:20:18 PDT

...

Attachments
Buffers already work (6.50 KB, patch) 2018-09-24 02:16 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
WIP (16.10 KB, patch) 2018-09-24 20:23 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch (13.74 KB, patch) 2018-09-25 15:00 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Depends on pointer equality (165.63 KB, patch) 2018-09-25 22:37 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2018-09-12 18:50:25 PDT

<rdar://problem/44402996>

Myles C. Maxfield

Comment 2 2018-09-22 04:03:15 PDT

We also have to figure out how to do things like device atomic_uint[] x : register(u0); InterlockedAdd(&x[0], 1, null);

Myles C. Maxfield

Comment 3 2018-09-22 16:52:12 PDT

*** Bug 177093 has been marked as a duplicate of this bug. ***

Myles C. Maxfield

Comment 4 2018-09-24 02:16:20 PDT

Created attachment 350627 [details] Buffers already work

Myles C. Maxfield

Comment 5 2018-09-24 02:17:43 PDT

The only things remaining are just to make sure you can't write to the constant address space, and make sure pointers the standard library functions work with all the appropriate address spaces.

Myles C. Maxfield

Comment 6 2018-09-24 02:18:15 PDT

Comment on attachment 350627 [details] Buffers already work View in context: https://bugs.webkit.org/attachment.cgi?id=350627&action=review > Tools/WebGPUShadingLanguageRI/Test.js:809 > +tests.threadArrayLoad = function() Poorly named

Myles C. Maxfield

Comment 7 2018-09-24 20:23:42 PDT

Created attachment 350731 [details] WIP

Myles C. Maxfield

Comment 8 2018-09-25 15:00:22 PDT

Created attachment 350796 [details] Patch

Myles C. Maxfield

Comment 9 2018-09-25 22:37:48 PDT

Created attachment 350849 [details] Depends on pointer equality

WebKit Commit Bot

Comment 10 2018-09-28 19:28:05 PDT

Comment on attachment 350849 [details] Depends on pointer equality Clearing flags on attachment: 350849 Committed r236635: <https://trac.webkit.org/changeset/236635>