Bug 98855

Summary: Add moveDoubleToInts and moveIntsToDouble to MacroAssemblerARM
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Blocker CC: barraclough, fpizlo, gaborb, galpeter, loki, oliver, ossy, rgabor, webkit.review.bot, zherczeg
Priority: P1 Keywords: Qt, QtTriaged
Version: 420+   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 98605    
Attachments:
Description Flags
speculative fix none

Csaba Osztrogonác
Reported 2012-10-09 22:03:29 PDT
http://trac.webkit.org/changeset/130839 broke the Qt ARM build, because 2 new functions introduced in it: - moveDoubleToInts - moveIntsToDouble But their implementation in ARMAssembler is still missing.
Attachments
speculative fix (1.71 KB, patch)
2012-10-10 00:53 PDT, Peter Gal 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Peter Gal
Comment 1 2012-10-10 00:53:06 PDT
Created attachment 167946 [details] speculative fix very speculative fix.
Filip Pizlo
Comment 2 2012-10-10 01:14:07 PDT
Comment on attachment 167946 [details] speculative fix This looks right. R=me.
WebKit Review Bot
Comment 3 2012-10-10 01:31:37 PDT
Comment on attachment 167946 [details] speculative fix Clearing flags on attachment: 167946 Committed r130872: <http://trac.webkit.org/changeset/130872>
WebKit Review Bot
Comment 4 2012-10-10 01:31:41 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.