Bug 98671

Summary: Upstream some tweaks for overlay play button on Android
Product: WebKit Reporter: Min Qin <qinmin>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, cmarcelo, eric.carlson, feature-media-reviews, macpherson, menard, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 66687    
Attachments:
Description Flags
Patch
none
Patch none

Min Qin
Reported 2012-10-08 11:35:03 PDT
Upstream some tweaks for overlay play button on Android
Attachments
Patch (1.53 KB, patch)
2012-10-08 11:38 PDT, Min Qin 		no flags
DetailsFormatted DiffDiff
Patch (1.76 KB, patch)
2012-10-08 12:02 PDT, Min Qin 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Min Qin
Comment 1 2012-10-08 11:38:50 PDT
Created attachment 167573 [details] Patch
Adam Barth
Comment 2 2012-10-08 11:51:59 PDT
Comment on attachment 167573 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=167573&action=review > Source/WebCore/css/mediaControlsChromiumAndroid.css:93 > + overflow:hidden; Looks like you're missing a space after the :
Min Qin
Comment 3 2012-10-08 12:02:15 PDT
Created attachment 167580 [details] Patch
Min Qin
Comment 4 2012-10-08 12:03:42 PDT
Oops. Sorry, fixed, also fixed some other offenders in the same file (In reply to comment #2) > (From update of attachment 167573 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=167573&action=review > > > Source/WebCore/css/mediaControlsChromiumAndroid.css:93 > > + overflow:hidden; > > Looks like you're missing a space after the :
Adam Barth
Comment 5 2012-10-08 12:25:08 PDT
Comment on attachment 167580 [details] Patch Thanks!
WebKit Review Bot
Comment 6 2012-10-08 13:58:39 PDT
Comment on attachment 167580 [details] Patch Clearing flags on attachment: 167580 Committed r130683: <http://trac.webkit.org/changeset/130683>
WebKit Review Bot
Comment 7 2012-10-08 13:58:43 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.