Bug 98605

Summary:

Typed arrays should not be 20x slower in the baseline JIT than in the DFG JIT

Product:

WebKit

Reporter:

Filip Pizlo <fpizlo>

Component:

JavaScriptCore

Assignee:

Filip Pizlo <fpizlo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ggaren, gyuyoung.kim, oliver, ossy, rakuco, simon.fraser, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

97288, 98855, 98856

Bug Blocks:

Attachments:

Description	Flags
work in progress, not rebased	none
the patch	oliver: review+, webkit-ews: commit-queue-
patch for landing	buildbot: commit-queue-

Filip Pizlo

Reported 2012-10-06 15:53:30 PDT

It's OK for the baseline JIT to be 2-4x slower than the DFG. But anything more than that makes me unhappy. Note that this depends on the baselineJIT get_by_val/put_by_val patching machinery from https://bugs.webkit.org/show_bug.cgi?id=97288

Attachments
work in progress, not rebased (336.67 KB, patch) 2012-10-08 19:24 PDT, Filip Pizlo	no flags	Details Formatted Diff Diff
the patch (47.06 KB, patch) 2012-10-09 17:25 PDT, Filip Pizlo	oliver: review+ webkit-ews: commit-queue-	Details Formatted Diff Diff
patch for landing (50.84 KB, patch) 2012-10-09 17:53 PDT, Filip Pizlo	buildbot: commit-queue-	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Filip Pizlo

Comment 1 2012-10-08 19:24:35 PDT

Created attachment 167673 [details] work in progress, not rebased This patch doesn't quite work yet (but it's already a >30% speed-up on some programs). It also includes all changes from an earlier version of https://bugs.webkit.org/show_bug.cgi?id=97288. I'll have to somehow rebase once that other thing lands.

Filip Pizlo

Comment 2 2012-10-09 17:25:59 PDT

Created attachment 167879 [details] the patch

Gavin Barraclough

Comment 3 2012-10-09 17:43:30 PDT

Comment on attachment 167879 [details] the patch r is me, too

Early Warning System Bot

Comment 4 2012-10-09 17:43:54 PDT

Comment on attachment 167879 [details] the patch Attachment 167879 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/14215948

Early Warning System Bot

Comment 5 2012-10-09 17:50:10 PDT

Comment on attachment 167879 [details] the patch Attachment 167879 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/14221905