Bug 97852

Summary: Remove unused features and reduce code duplications in PerfTestRunner
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: New BugsAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, haraken, morrita, ojan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 97833    
Attachments:
Description Flags
Patch
none
Fixed a typo in ChangeLog haraken: review+

Ryosuke Niwa
Reported 2012-09-27 20:29:20 PDT
Remove unused features and reduce code duplications in PerfTestRunner
Attachments
Patch (8.16 KB, patch)
2012-09-27 20:40 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Fixed a typo in ChangeLog (8.16 KB, patch)
2012-09-27 20:56 PDT, Ryosuke Niwa 		haraken: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2012-09-27 20:40:28 PDT
Created attachment 166132 [details] Patch
Kentaro Hara
Comment 2 2012-09-27 20:50:49 PDT
Comment on attachment 166132 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=166132&action=review > PerformanceTests/ChangeLog:9 > + - Remove PerfTestRunner.log since it's never used. Nit: PerfTestRunner.info? > PerformanceTests/resources/runner.js:190 > + return returnValue; > + } > > - var mallocMemoryStats = PerfTestRunner.computeStatistics([PerfTestRunner.getUsedMallocHeap()], "bytes"); > - PerfTestRunner.printStatistics(mallocMemoryStats, "Malloc:"); > + return end - start; Is this correct? This function sometimes returns returnValue and sometimes returns end-start.
Ryosuke Niwa
Comment 3 2012-09-27 20:55:33 PDT
Comment on attachment 166132 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=166132&action=review >> PerformanceTests/ChangeLog:9 >> + - Remove PerfTestRunner.log since it's never used. > > Nit: PerfTestRunner.info? Right. >> PerformanceTests/resources/runner.js:190 >> + return end - start; > > Is this correct? This function sometimes returns returnValue and sometimes returns end-start. Yes. When test.run returns a number, we use that value instead (see dom-perf.js for example).
Ryosuke Niwa
Comment 4 2012-09-27 20:56:15 PDT
Created attachment 166136 [details] Fixed a typo in ChangeLog
Kentaro Hara
Comment 5 2012-09-27 21:08:20 PDT
Comment on attachment 166136 [details] Fixed a typo in ChangeLog Looks OK
Note You need to log in before you can comment on or make changes to this bug.