Bug 97741

Summary: PerformanceTests/CSS/StyleSheetInsert.html has a time-dependent non-Gaussian distribution
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: Tools / TestsAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: kling, koivisto, morrita, ojan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 77037, 97743    
Attachments:
Description Flags
Results page illustrating the problem
none
Fixes the bug none

Ryosuke Niwa
Reported 2012-09-26 16:48:41 PDT
http://trac.webkit.org/browser/trunk/PerformanceTests/CSS/StyleSheetInsert.html's run function adds new nodes in each run but doesn't remove them. As a result, run gets slower on each call, resulting in values like: 22.0, 26.0, 27.0, 31.0, 33.0, 35.0, 37.0, 43.0, 44.0, 45.0 We need to remove the nodes added in each run so that values follow a normal distribution.
Attachments
Results page illustrating the problem (20.60 KB, text/html)
2012-09-26 16:49 PDT, Ryosuke Niwa 		no flags
Details
Fixes the bug (2.41 KB, patch)
2012-09-26 16:53 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2012-09-26 16:49:29 PDT
Created attachment 165897 [details] Results page illustrating the problem
Ryosuke Niwa
Comment 2 2012-09-26 16:53:01 PDT
Created attachment 165898 [details] Fixes the bug
Ryosuke Niwa
Comment 3 2012-09-26 17:04:31 PDT
Note that the results obtained after this patch is included in the first attachment. Notice the standard deviation went down from ~25% to ~8%.
Ryosuke Niwa
Comment 4 2012-09-27 15:24:04 PDT
I'm making results page warn time-dependent distributions in https://bugs.webkit.org/show_bug.cgi?id=97818 so that we can detect these problems easily.
Ryosuke Niwa
Comment 5 2012-09-27 16:38:16 PDT
This bug is beautifully visualized in https://bug-97818-attachments.webkit.org/attachment.cgi?id=166055.
Ryosuke Niwa
Comment 6 2012-09-27 16:38:44 PDT
Comment on attachment 165898 [details] Fixes the bug Clearing flags on attachment: 165898 Committed r129817: <http://trac.webkit.org/changeset/129817>
Ryosuke Niwa
Comment 7 2012-09-27 16:38:46 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.