Bug 97167

Summary: [Chromium] Implement ValidationMessageClient for Chromium
Product: WebKit Reporter: Kent Tamura <tkent>
Component: WebKit APIAssignee: Kent Tamura <tkent>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, fishd, jamesr, morrita, tkent+wkapi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 95527    
Attachments:
Description Flags
Patch
none
Patch 2 none

Kent Tamura
Reported 2012-09-19 22:03:35 PDT
[Chromium] Implement ValidationMessageClient for Chromium
Attachments
Patch (13.84 KB, patch)
2012-09-19 22:13 PDT, Kent Tamura 		no flags
DetailsFormatted DiffDiff
Patch 2 (13.86 KB, patch)
2012-09-20 18:12 PDT, Kent Tamura 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kent Tamura
Comment 1 2012-09-19 22:13:04 PDT
Created attachment 164838 [details] Patch
WebKit Review Bot
Comment 2 2012-09-19 22:15:39 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Adam Barth
Comment 3 2012-09-20 10:47:50 PDT
Comment on attachment 164838 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=164838&action=review > Source/WebKit/chromium/src/ValidationMessageClientImpl.h:42 > + ValidationMessageClientImpl(WebViewClient&); explicit
Adam Barth
Comment 4 2012-09-20 10:48:33 PDT
Comment on attachment 164838 [details] Patch API change LGTM
Kent Tamura
Comment 5 2012-09-20 18:12:42 PDT
Created attachment 165027 [details] Patch 2 Add explicit
Hajime Morrita
Comment 6 2012-09-24 18:50:20 PDT
Comment on attachment 165027 [details] Patch 2 rs=me
WebKit Review Bot
Comment 7 2012-09-24 19:15:48 PDT
Comment on attachment 165027 [details] Patch 2 Clearing flags on attachment: 165027 Committed r129443: <http://trac.webkit.org/changeset/129443>
WebKit Review Bot
Comment 8 2012-09-24 19:15:52 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.