Bug 96397

Summary: [Qt][WK2] fast/spatial-navigation/snav-media-elements.html timeouts
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: New BugsAssignee: Allan Sandfeld Jensen <allan.jensen>
Status: RESOLVED INVALID    
Severity: Normal CC: allan.jensen, eric.carlson, feature-media-reviews, hausmann, kenneth, mikhail.pozdnyakov, ossy, tonikitoo, webkit.review.bot
Priority: P2 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 79668, 96269    
Attachments:
Description Flags
Patch none

Csaba Osztrogonác
Reported 2012-09-11 09:01:07 PDT
fast/spatial-navigation tests was unskipped by https://trac.webkit.org/changeset/128186 but it this one fail with timeout on Qt WK2: --- /home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/layout-test-results/fast/spatial-navigation/snav-media-elements-expected.txt +++ /home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/layout-test-results/fast/spatial-navigation/snav-media-elements-actual.txt @@ -1,28 +1,2 @@ -This is a link start of Test. +FAIL: Timed out waiting for notifyDone to be called -This is a link i2. - -This is a link i4. - -This is a link i6. - -This is a link i8. - -This is a link End of Test. - -PASS gFocusedDocument.activeElement.getAttribute("id") is "start" -PASS gFocusedDocument.activeElement.getAttribute("id") is "v1" -PASS gFocusedDocument.activeElement.getAttribute("id") is "i2" -PASS gFocusedDocument.activeElement.getAttribute("id") is "v3" -PASS gFocusedDocument.activeElement.getAttribute("id") is "i4" -PASS gFocusedDocument.activeElement.getAttribute("id") is "v5" -PASS gFocusedDocument.activeElement.getAttribute("id") is "i6" -PASS gFocusedDocument.activeElement.getAttribute("id") is "a7" -PASS gFocusedDocument.activeElement.getAttribute("id") is "i8" -PASS gFocusedDocument.activeElement.getAttribute("id") is "end" -PASS gFocusedDocument.activeElement.getAttribute("id") is "i8" -PASS gFocusedDocument.activeElement.getAttribute("id") is "end" -PASS successfullyParsed is true - -TEST COMPLETE -This tests that a media elements ie: <Audio> or <video>, without tabindex are able to be reached through keyboard access
Attachments
Patch (2.69 KB, patch)
2012-09-12 05:27 PDT, Allan Sandfeld Jensen 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1 2012-09-11 09:09:46 PDT
I skipped it - https://trac.webkit.org/changeset/128193
Allan Sandfeld Jensen
Comment 2 2012-09-12 05:20:45 PDT
It does not timeout here. Could it be flaky?
Allan Sandfeld Jensen
Comment 3 2012-09-12 05:27:42 PDT
Created attachment 163599 [details] Patch
Allan Sandfeld Jensen
Comment 4 2012-09-12 05:28:48 PDT
(In reply to comment #3) > Created an attachment (id=163599) [details] > Patch I couldn't make it timeout on my machine, but perhaps this helps?
Simon Hausmann
Comment 5 2012-09-13 22:29:40 PDT
Antonio, can you help us review this change to the spatial navigation tests? :)
WebKit Review Bot
Comment 6 2012-09-20 01:21:43 PDT
Comment on attachment 163599 [details] Patch Clearing flags on attachment: 163599 Committed r129103: <http://trac.webkit.org/changeset/129103>
WebKit Review Bot
Comment 7 2012-09-20 01:21:46 PDT
All reviewed patches have been landed. Closing bug.
Csaba Osztrogonác
Comment 8 2012-09-20 07:15:37 PDT
Reopen, because it still fails with timeout.
Csaba Osztrogonác
Comment 9 2012-09-25 03:27:28 PDT
(In reply to comment #8) > Reopen, because it still fails with timeout. ... and skipped again to paint the bot green - https://trac.webkit.org/changeset/129475
Jocelyn Turcotte
Comment 10 2014-02-03 03:22:38 PST
=== Bulk closing of Qt bugs === If you believe that this bug report is still relevant for a non-Qt port of webkit.org, please re-open it and remove [Qt] from the summary. If you believe that this is still an important QtWebKit bug, please fill a new report at https://bugreports.qt-project.org and add a link to this issue. See http://qt-project.org/wiki/ReportingBugsInQt for additional guidelines.
Note You need to log in before you can comment on or make changes to this bug.