Bug 96358

Summary: [Qt] Build on Windows requires bison/flex in PATH
Product: WebKit Reporter: Simon Hausmann <hausmann>
Component: New BugsAssignee: Simon Hausmann <hausmann>
Status: RESOLVED FIXED    
Severity: Normal CC: abecsi, dino, kevin.funk, vestbo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 96359    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Simon Hausmann
Reported 2012-09-11 00:21:02 PDT
[Qt] Build on Windows requires bison/flex in PATH
Attachments
Patch (4.26 KB, patch)
2012-09-11 00:26 PDT, Simon Hausmann 		no flags
DetailsFormatted DiffDiff
Patch (5.82 KB, patch)
2012-09-11 01:57 PDT, Simon Hausmann 		no flags
DetailsFormatted DiffDiff
Patch (6.11 KB, patch)
2012-09-11 23:54 PDT, Simon Hausmann 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Simon Hausmann
Comment 1 2012-09-11 00:26:45 PDT
Created attachment 163292 [details] Patch
Simon Hausmann
Comment 2 2012-09-11 01:57:53 PDT
Created attachment 163305 [details] Patch Updated patch to accomodate ANGLE windows build
Simon Hausmann
Comment 3 2012-09-11 23:54:17 PDT
Created attachment 163526 [details] Patch Updated patch that modifies the tools-in-PATH check on Windows to look for win_flex instead of flex
WebKit Review Bot
Comment 4 2012-09-12 07:34:40 PDT
Comment on attachment 163305 [details] Patch Clearing flags on attachment: 163305 Committed r128308: <http://trac.webkit.org/changeset/128308>
WebKit Review Bot
Comment 5 2012-09-12 07:34:44 PDT
All reviewed patches have been landed. Closing bug.
Kevin Funk
Comment 6 2012-09-12 09:02:12 PDT
Note: This patch breaks the generator commands in case GNUTOOLS references an invalid directory, please reconsider. '$${GNUTOOLS} && $$val_escape($${generator}.commands)' then evaluates to 'SOME_DIR && ...' which breaks compilation.
Simon Hausmann
Comment 7 2012-09-12 09:34:11 PDT
(In reply to comment #6) > Note: This patch breaks the generator commands in case GNUTOOLS references an invalid directory, please reconsider. > > '$${GNUTOOLS} && $$val_escape($${generator}.commands)' then evaluates to 'SOME_DIR && ...' which breaks compilation. Ooops! Well spotted. I'll fix it right away.
Simon Hausmann
Comment 8 2012-09-12 09:43:09 PDT
Prospectively fixed in http://trac.webkit.org/changeset/128328
Note You need to log in before you can comment on or make changes to this bug.