Bug 96246

Summary: [WK2] Make WK2 C API headers compile in the Qt build on Windows
Product: WebKit Reporter: Simon Hausmann <hausmann>
Component: New BugsAssignee: Simon Hausmann <hausmann>
Status: RESOLVED FIXED    
Severity: Normal CC: vestbo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 76776    
Attachments:
Description Flags
Patch none

Simon Hausmann
Reported 2012-09-10 01:41:38 PDT
[WK2] Make WK2 C API headers compile in the Qt build on Windows
Attachments
Patch (2.07 KB, patch)
2012-09-10 01:43 PDT, Simon Hausmann 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Hausmann
Comment 1 2012-09-10 01:43:51 PDT
Created attachment 163067 [details] Patch
Kenneth Rohde Christiansen
Comment 2 2012-09-10 01:49:44 PDT
Comment on attachment 163067 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=163067&action=review > Source/WebKit2/Shared/API/c/WKBase.h:32 > +#if (defined(WIN32) || defined(_WIN32)) && !defined(BUILDING_QT__) This couldn't be PLATFORM(WIN) && instead?
Simon Hausmann
Comment 3 2012-09-10 02:05:01 PDT
Comment on attachment 163067 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=163067&action=review >> Source/WebKit2/Shared/API/c/WKBase.h:32 >> +#if (defined(WIN32) || defined(_WIN32)) && !defined(BUILDING_QT__) > > This couldn't be PLATFORM(WIN) && instead? Unfortunately no, as that would require including config.h and WTF's Platform.h, both of which are not available when these header files are used on the application side.
WebKit Review Bot
Comment 4 2012-09-10 02:09:02 PDT
Comment on attachment 163067 [details] Patch Clearing flags on attachment: 163067 Committed r128033: <http://trac.webkit.org/changeset/128033>
WebKit Review Bot
Comment 5 2012-09-10 02:09:05 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.