Bug 95369

Summary: [CSS Exclusions] Exclusions tests should run without errors in standalone browser
Product: WebKit Reporter: Bear Travis <betravis>
Component: CSSAssignee: Bear Travis <betravis>
Status: RESOLVED FIXED    
Severity: Normal CC: donggwan.kim, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 89256    
Attachments:
Description Flags
Fixing up the exclusions and shape-inside tests none

Bear Travis
Reported 2012-08-29 12:56:49 PDT
The exclusions tests currently enable/disable css exclusions through window.internals.settings, which is not available in standalone browsers. Opening these pages in a standalone browser causes a reference error. The tests should instead test for the existence of internals before attempting to reference it.
Attachments
Fixing up the exclusions and shape-inside tests (10.03 KB, patch)
2012-08-29 13:18 PDT, Bear Travis 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Bear Travis
Comment 1 2012-08-29 13:18:19 PDT
Created attachment 161296 [details] Fixing up the exclusions and shape-inside tests
WebKit Review Bot
Comment 2 2012-08-31 02:40:34 PDT
Comment on attachment 161296 [details] Fixing up the exclusions and shape-inside tests Clearing flags on attachment: 161296 Committed r127241: <http://trac.webkit.org/changeset/127241>
WebKit Review Bot
Comment 3 2012-08-31 02:40:37 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.