Bug 94578
| Summary: | REGRESSION (r126132): fast/forms/range/range-hit-test-with-padding.html failing on non-Chromium ports | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Zan Dobersek <zan> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | beidson, keishi, ossy, tmpsantos |
| Priority: | P2 | Keywords: | LayoutTestFailure, MakingBotsRed, Qt, QtTriaged, Regression |
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| URL: | http://build.webkit.org/results/GTK%20Linux%2064-bit%20Release/r126132%20(27786)/results.html | ||
| Bug Depends on: | |||
| Bug Blocks: | 87008, 94473 | ||
Zan Dobersek
fast/forms/range/range-hit-test-with-padding.html started failing on non-Chromium ports after r126132.
The diff looks something like this (the actual value is about 506 or 507):
--- /home/slave/webkitgtk/gtk-linux-64-release/build/layout-test-results/fast/forms/range/range-hit-test-with-padding-expected.txt
+++ /home/slave/webkitgtk/gtk-linux-64-release/build/layout-test-results/fast/forms/range/range-hit-test-with-padding-actual.txt
@@ -1,6 +1,6 @@
Clicking middle of input type=range with padding should set the value to middle.
-PASS input.value is "500"
+FAIL input.value should be 500. Was 507.
PASS successfullyParsed is true
TEST COMPLETE
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Thiago Marcos P. Santos
Discrepancy is even higher on EFL:
-PASS input.value is "500"
+FAIL input.value should be 500. Was 727.
Csaba Osztrogonác
It is skipped on Qt - https://trac.webkit.org/changeset/126149
Keishi Hattori
(In reply to comment #1)
> Discrepancy is even higher on EFL:
>
> -PASS input.value is "500"
> +FAIL input.value should be 500. Was 727.
I learned that ports without subpixel layout will not be able to match the value exactly. I am modifying the test in Bug 94585.
Qt should rebaseline when it lands.
But EFL is way off so there might be something else going on. I can't figure it out.
Thiago Marcos P. Santos
(In reply to comment #3)
> (In reply to comment #1)
> > Discrepancy is even higher on EFL:
> >
> > -PASS input.value is "500"
> > +FAIL input.value should be 500. Was 727.
>
> I learned that ports without subpixel layout will not be able to match the value exactly. I am modifying the test in Bug 94585.
> Qt should rebaseline when it lands.
> But EFL is way off so there might be something else going on. I can't figure it out.
- clickSlider(70); // left padding (20px) + middle (50px)
+ clickSlider(50); // middle (50px)
Hits bull's-eye (500) on EFL. I'm investigating why.
Keishi Hattori
Bug 94585 is in the commit queue. I was able to change the test in a way that you won't need to rebaseline.
Csaba Osztrogonác
(In reply to comment #5)
> Bug 94585 is in the commit queue. I was able to change the test in a way that you won't need to rebaseline.
It fixed it on Qt, unskip landed in https://trac.webkit.org/changeset/128444
Zan Dobersek
(In reply to comment #5)
> Bug 94585 is in the commit queue. I was able to change the test in a way that you won't need to rebaseline.
Great, the test is now running OK, closing the bug.