Bug 94024

Created attachment 158859 [details] first patch to see if everything still builds

Comment on attachment 158859 [details] first patch to see if everything still builds Attachment 158859 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13510733 New failing tests: css3/compositing/blend-mode-property-parsing.html css3/compositing/blend-mode-property.html css3/compositing/blend-mode-property-parsing-invalid.html

Created attachment 158889 [details] Archive of layout-test-results from gce-cr-linux-06 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: gce-cr-linux-06 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid

Comment on attachment 158859 [details] first patch to see if everything still builds Attachment 158859 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13521106 New failing tests: css3/compositing/blend-mode-property-parsing.html css3/compositing/blend-mode-property.html css3/compositing/blend-mode-property-parsing-invalid.html

Created attachment 158905 [details] Archive of layout-test-results from gce-cr-linux-02 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: gce-cr-linux-02 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid

Created attachment 158921 [details] second patch with test results

Comment on attachment 158921 [details] second patch with test results View in context: https://bugs.webkit.org/attachment.cgi?id=158921&action=review The patch LGTM. Just the tests need more tweaks. > Source/WebCore/ChangeLog:8 > + Added parsing and general CSS handling of -webkit-blend-mode per http://www.w3.org/TR/2012/WD-compositing-20120816/ Link to WD, wow! :D > LayoutTests/css3/compositing/script-tests/blend-mode-property-parsing.js:47 > +testFilterRule("Basic reference", > + "multiply", 1, "multiply"); I would like to see a test for all keywords, not just 'multiply' so that we can make sure that we support all and not accidentally remove support of one. This can be done with a simple for-loop on an array ["multiply", '"normal", ....]. > LayoutTests/css3/compositing/script-tests/blend-mode-property.js:16 > +var declaration = cssRule.style; > +shouldBe("declaration.length", "1"); > +shouldBe("declaration.getPropertyValue('-webkit-blend-mode')", "\'multiply\'"); Same comment as above.

Created attachment 159268 [details] patch that tests all blendmodes

Comment on attachment 159268 [details] patch that tests all blendmodes Attachment 159268 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13530402 New failing tests: css3/compositing/blend-mode-property-parsing.html css3/compositing/blend-mode-property.html

Created attachment 159269 [details] Archive of layout-test-results from gce-cr-linux-07 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: gce-cr-linux-07 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid

Comment on attachment 159268 [details] patch that tests all blendmodes Attachment 159268 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13521793 New failing tests: css3/compositing/blend-mode-property-parsing.html css3/compositing/blend-mode-property.html

Created attachment 159273 [details] Archive of layout-test-results from gce-cr-linux-04 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: gce-cr-linux-04 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid

Created attachment 159274 [details] updated result file

Created attachment 159275 [details] updated result file

Comment on attachment 159275 [details] updated result file View in context: https://bugs.webkit.org/attachment.cgi?id=159275&action=review just some snippets left. > LayoutTests/css3/compositing/script-tests/blend-mode-property-parsing.js:46 > +testFilterRule("Basic reference", use the same array like for blend-mode-propery.js. Rename testFilterRule to testBlendModeRule.

Created attachment 159303 [details] expanded second test

Comment on attachment 159303 [details] expanded second test Attachment 159303 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13537513 New failing tests: css3/compositing/blend-mode-property-parsing.html

Created attachment 159305 [details] Archive of layout-test-results from gce-cr-linux-03 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: gce-cr-linux-03 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid

Created attachment 159310 [details] fixed changelog + patched expected text for test

Comment on attachment 159310 [details] fixed changelog + patched expected text for test LGTM. r=me.

Comment on attachment 159310 [details] fixed changelog + patched expected text for test Clearing flags on attachment: 159310 Committed r125989: <http://trac.webkit.org/changeset/125989>

All reviewed patches have been landed. Closing bug.

css3/compositing/blend-mode-property-parsing.html and css3/compositing/blend-mode-property.html Have been failing on the Mac bots since check-in.

(In reply to comment #23) > css3/compositing/blend-mode-property-parsing.html > and > css3/compositing/blend-mode-property.html > > Have been failing on the Mac bots since check-in. Example failures: http://build.webkit.org/results/Apple%20Lion%20Debug%20WK1%20(Tests)/r126026%20(2039)/results.html

Re-opened since this is blocked by 94485

Created attachment 159454 [details] added platform specific test files

Created attachment 159455 [details] added missing result file

Created attachment 159490 [details] moved files around

Comment on attachment 159490 [details] moved files around second try. r=me.

Sorry about the rollout this morning guys. Thanks for following up with green tests!

Comment on attachment 159490 [details] moved files around Rejecting attachment 159490 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: Kit/chromium/third_party/yasm/source/patched-yasm --revision 134927 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 50>At revision 134927. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/13545224

Created attachment 159570 [details] did a sync to resolve conflict

Comment on attachment 159570 [details] did a sync to resolve conflict Clearing flags on attachment: 159570 Committed r126105: <http://trac.webkit.org/changeset/126105>

All reviewed patches have been landed. Closing bug.