Bug 93464

Summary: Rename two methods of BitmapImage in order to clarify the intention: frameDurationAtIndex() and frameIsCompleteAtIndex().
Product: WebKit Reporter: Dongseong Hwang <dongseong.hwang>
Component: ImagesAssignee: Nobody <webkit-unassigned>
Status: UNCONFIRMED    
Severity: Normal CC: dglazkov, gustavo, hclam, senorblanco, skyul, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 90375, 93467    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Dongseong Hwang
Reported 2012-08-08 04:58:25 PDT
There are three methods which can trigger image decoding: ImageSource::createFrameAtIndex() ImageSource::frameIsCompleteAtIndex() ImageSource::frameDurationAtIndex() frameIsCompleteAtIndex() and frameDurationAtIndex() make us confused because both methods can trigger image decoding although the name of both methods do not look so. This patch renames frameDurationAtIndex() and frameIsCompleteAtIndex() to frameDurationAtIndexDecodingIfNecessary() and frameIsCompleteAtIndexDecodingIfNecessary() respectively. BitmapImage has the wrappers of both methods, so this patch renames those wrappers too. It is a preparation patch for implementing an async image decoder. Both methods are not plane getters, so developers need to be careful when using these methods. Otherwise, sync or async image decoding will be triggered, which is an unexpected behavior.
Attachments
Patch (12.20 KB, patch)
2012-08-08 05:00 PDT, Dongseong Hwang 		no flags
DetailsFormatted DiffDiff
Patch (7.17 KB, patch)
2012-08-09 00:10 PDT, Dongseong Hwang 		no flags
DetailsFormatted DiffDiff
Patch (6.07 KB, patch)
2012-08-09 00:44 PDT, Dongseong Hwang 		no flags
DetailsFormatted DiffDiff
Patch (6.18 KB, patch)
2012-08-15 23:24 PDT, Dongseong Hwang 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Dongseong Hwang
Comment 1 2012-08-08 05:00:59 PDT
Created attachment 157184 [details] Patch
Gyuyoung Kim
Comment 2 2012-08-08 05:15:22 PDT
Comment on attachment 157184 [details] Patch Attachment 157184 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/13457443
WebKit Review Bot
Comment 3 2012-08-08 05:23:54 PDT
Comment on attachment 157184 [details] Patch Attachment 157184 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13462063
Early Warning System Bot
Comment 4 2012-08-08 05:30:33 PDT
Comment on attachment 157184 [details] Patch Attachment 157184 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/13461133
Early Warning System Bot
Comment 5 2012-08-08 05:43:46 PDT
Comment on attachment 157184 [details] Patch Attachment 157184 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/13458238
Gustavo Noronha (kov)
Comment 6 2012-08-08 06:10:38 PDT
Comment on attachment 157184 [details] Patch Attachment 157184 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/13454493
Dongseong Hwang
Comment 7 2012-08-08 19:17:19 PDT
This patch was implemented based on Bug 93171, so all build bots failed. I'll post this patch again after landing Bug 93171.
Dongseong Hwang
Comment 8 2012-08-09 00:10:43 PDT
Created attachment 157403 [details] Patch
Dongseong Hwang
Comment 9 2012-08-09 00:26:17 PDT
(In reply to comment #8) > Created an attachment (id=157403) [details] > Patch The first patch renamed two methods of ImageSource as well as two methods of BitmapImage. But this patch renamed only those of BitmapImage, because Bug 93467 prevents clients, except for BitmapImage, from using two methods of ImageSource.
Build Bot
Comment 10 2012-08-09 00:32:48 PDT
Comment on attachment 157403 [details] Patch Attachment 157403 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/13458598
Build Bot
Comment 11 2012-08-09 00:35:08 PDT
Comment on attachment 157403 [details] Patch Attachment 157403 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/13462388
Dongseong Hwang
Comment 12 2012-08-09 00:44:57 PDT
Created attachment 157409 [details] Patch
Dongseong Hwang
Comment 13 2012-08-15 23:24:46 PDT
Created attachment 158718 [details] Patch
Dongseong Hwang
Comment 14 2012-08-15 23:26:21 PDT
(In reply to comment #13) > Created an attachment (id=158718) [details] > Patch Rebased to the upstream
Andreas Kling
Comment 15 2014-02-05 10:51:25 PST
Comment on attachment 158718 [details] Patch Clearing review flag on patches from before 2014. If this patch is still relevant, please reset the r? flag.
Note You need to log in before you can comment on or make changes to this bug.