Bug 93294

Summary: REGRESSION(r124780): This patch broke the Adroid build (Requested by annacc on #webkit).
Product: WebKit Reporter: WebKit Review Bot <webkit.review.bot>
Component: New BugsAssignee: WebKit Review Bot <webkit.review.bot>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: annacc, eric.carlson
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 91773    
Attachments:
Description Flags
ROLLOUT of r124780 webkit.review.bot: commit-queue-

WebKit Review Bot
Reported 2012-08-06 13:20:55 PDT
http://trac.webkit.org/changeset/124780 broke the build: This patch broke the Adroid build (Requested by annacc on #webkit). This is an automatic bug report generated by the sheriff-bot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests case pain. "Only you can prevent forest fires." -- Smokey the Bear
Attachments
ROLLOUT of r124780 (42.88 KB, patch)
2012-08-06 13:21 PDT, WebKit Review Bot 		webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
WebKit Review Bot
Comment 1 2012-08-06 13:21:44 PDT
Created attachment 156753 [details] ROLLOUT of r124780 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment.
Anna Cavender
Comment 2 2012-08-06 13:42:38 PDT
Landed a fix in r124798 rather than reverting.
Anna Cavender
Comment 3 2012-08-06 22:53:22 PDT
Going ahead and reverting this patch so that we have a consistent Media Source Extensions version for the chromium branch cut.
WebKit Review Bot
Comment 4 2012-08-06 22:56:14 PDT
Comment on attachment 156753 [details] ROLLOUT of r124780 Rejecting attachment 156753 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: ore/dom/EventTarget.h patching file Source/WebCore/dom/EventTargetFactory.in patching file Source/WebCore/html/DOMURL.cpp Hunk #2 FAILED at 49. 1 out of 2 hunks FAILED -- saving rejects to file Source/WebCore/html/DOMURL.cpp.rej patching file Source/WebCore/html/DOMURL.h patching file Source/WebCore/html/DOMURL.idl patching file Source/WebCore/page/DOMWindow.idl Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/13452155
Anna Cavender
Comment 5 2012-08-06 23:41:01 PDT
Looks like this patch was a bit stale. Created a new one for the revert *** This bug has been marked as a duplicate of bug 93340 ***
Note You need to log in before you can comment on or make changes to this bug.