Bug 92484

Summary: [EFL][WK2] Add API to Ewk_Cookie_Manager to watch for cookie changes
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: gustavo, gyuyoung.kim, hausmann, kenneth, rakuco, ryuan.choi, tmpsantos, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 61838    
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2012-07-27 03:32:51 PDT
There is currently no way for the client to get notified whenever cookies are added, modified or removed. We need to provide such functionality in Ewk_Cookie_Manager.
Attachments
Patch (11.14 KB, patch)
2012-07-27 03:38 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (11.22 KB, patch)
2012-07-27 05:45 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2012-07-27 03:38:38 PDT
Created attachment 154895 [details] Patch
Kenneth Rohde Christiansen
Comment 2 2012-07-27 04:47:34 PDT
Comment on attachment 154895 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=154895&action=review > Source/WebKit2/UIProcess/API/efl/ewk_cookie_manager.cpp:44 > +struct Watch_Changes_Callback_Data { > + Ewk_Cookie_Manager_Changes_Watch_Cb callback; I dont think the Data here is such a good addition given that it is containing an actual callback. Is this stuct even needed. It seems as you can only have one callback with user data > Source/WebKit2/UIProcess/API/efl/ewk_cookie_manager.cpp:66 > + Watch_Changes_Callback_Data changeWatcher; The naming seems a bit weird here given the name of the variable and the name of the struct. A watcher indicates something active
Chris Dumez
Comment 3 2012-07-27 05:33:48 PDT
Comment on attachment 154895 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=154895&action=review >> Source/WebKit2/UIProcess/API/efl/ewk_cookie_manager.cpp:44 >> + Ewk_Cookie_Manager_Changes_Watch_Cb callback; > > I dont think the Data here is such a good addition given that it is containing an actual callback. Is this stuct even needed. It seems as you can only have one callback with user data I would prefer to keep the struct since this is the approach I have used in order files for callbacks + userData. I think it is more scalable. How about renaming _Data with _Handler then? >> Source/WebKit2/UIProcess/API/efl/ewk_cookie_manager.cpp:66 >> + Watch_Changes_Callback_Data changeWatcher; > > The naming seems a bit weird here given the name of the variable and the name of the struct. A watcher indicates something active You're right. How about changeHandler then?
Kenneth Rohde Christiansen
Comment 4 2012-07-27 05:40:10 PDT
ok fine
Chris Dumez
Comment 5 2012-07-27 05:45:47 PDT
Created attachment 154913 [details] Patch Take Kenneth's feedback into consideration.
WebKit Review Bot
Comment 6 2012-07-27 06:40:01 PDT
Comment on attachment 154913 [details] Patch Clearing flags on attachment: 154913 Committed r123870: <http://trac.webkit.org/changeset/123870>
WebKit Review Bot
Comment 7 2012-07-27 06:40:08 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.