Bug 92217

Summary: A validation bubble should not be modifiable
Product: WebKit Reporter: Shinya Kawanaka <shinyak>
Component: DOMAssignee: Shinya Kawanaka <shinyak>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, macpherson, menard, morrita, rniwa, roger_fong, tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 65738    
Attachments:
Description Flags
Patch
none
Patch none

Shinya Kawanaka
Reported 2012-07-24 23:34:06 PDT
As the other elements in UserAgentShadowDOM, validation bubble should not be modifiable.
Attachments
Patch (5.61 KB, patch)
2012-07-25 02:02 PDT, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
Patch (5.75 KB, patch)
2012-07-25 02:33 PDT, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Shinya Kawanaka
Comment 1 2012-07-25 00:19:34 PDT
It's hard to write a test... The validation box disappears when I try to edit. How should we try to test this..?
Kent Tamura
Comment 2 2012-07-25 00:23:26 PDT
(In reply to comment #1) > It's hard to write a test... The validation box disappears when I try to edit. > How should we try to test this..? Settings::setValidationMessageTimerMagnification(0) ? It's 0 in DRT.
Shinya Kawanaka
Comment 3 2012-07-25 01:59:21 PDT
(In reply to comment #2) > (In reply to comment #1) > > It's hard to write a test... The validation box disappears when I try to edit. > > How should we try to test this..? > > Settings::setValidationMessageTimerMagnification(0) ? > It's 0 in DRT. Thanks. I could write a test.
Shinya Kawanaka
Comment 4 2012-07-25 02:02:20 PDT
Created attachment 154296 [details] Patch
Kent Tamura
Comment 5 2012-07-25 02:08:03 PDT
Comment on attachment 154296 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=154296&action=review > Source/WebCore/ChangeLog:19 > + (::-webkit-validation-bubble): > + (::-webkit-validation-bubble-message): > + (::-webkit-validation-bubble-text-block): > + (::-webkit-validation-bubble-heading): > + (::-webkit-validation-bubble-arrow): > + (::-webkit-validation-bubble-arrow-clipper): Write what you changed and the reason. > LayoutTests/ChangeLog:9 > + * fast/forms/validation-user-modify.html: Added. The test file name should start with validation-message- to follow other existing tests. > LayoutTests/fast/forms/validation-user-modify.html:31 > +if (window.testRunner) > + testRunner.waitUntilDone(); should be replaced with jsTestIsAsync = true;. > LayoutTests/fast/forms/validation-user-modify.html:52 > + if (window.testRunner) > + testRunner.notifyDone(); should be replaced with finishJSTest();.
Shinya Kawanaka
Comment 6 2012-07-25 02:33:14 PDT
Created attachment 154303 [details] Patch
Kent Tamura
Comment 7 2012-07-25 02:34:56 PDT
Comment on attachment 154303 [details] Patch ok
WebKit Review Bot
Comment 8 2012-07-25 03:09:38 PDT
Comment on attachment 154303 [details] Patch Clearing flags on attachment: 154303 Committed r123598: <http://trac.webkit.org/changeset/123598>
WebKit Review Bot
Comment 9 2012-07-25 03:09:43 PDT
All reviewed patches have been landed. Closing bug.
Roger Fong
Comment 10 2012-08-06 17:39:07 PDT
Hello, I think that the test should involve some sort of focus check to make sure that when you're deleting things you're actually in the validation bubble. If the validation bubble fails to show up (or somehow the test 'misses' the validation bubble and tries to delete from nothing) the test will falsely pass.
Note You need to log in before you can comment on or make changes to this bug.