Bug 92200

Summary: The elements in Shadow DOM of input should not be modifiable
Product: WebKit Reporter: Shinya Kawanaka <shinyak>
Component: DOMAssignee: Shinya Kawanaka <shinyak>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, macpherson, menard, morrita, rniwa, tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 65738    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch for landing
none
Patch for landing none

Shinya Kawanaka
Reported 2012-07-24 20:44:55 PDT
According to Bug 65738 comment, we have the following bugs. 1. Load data:text/html,<style>input::-webkit-textfield-decoration-container { -webkit-user-modify: read-write; }</style><input type=search> 2. Focus on the search field 3. Press backward-delete key 4. Crash Another related issue: 1. Load data:text/html,<style>input::-webkit-search-results-button { -webkit-user-modify: read-write; }</style><input type=search results=20> 2. Right-click on the magnifier button. 3. You can type into the magnifier button.
Attachments
Patch (8.72 KB, patch)
2012-07-24 23:19 PDT, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
Patch (8.67 KB, patch)
2012-07-25 19:06 PDT, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
Patch (9.80 KB, patch)
2012-07-30 21:29 PDT, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
Patch (9.97 KB, patch)
2012-07-30 22:04 PDT, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
Patch for landing (9.83 KB, patch)
2012-07-31 23:30 PDT, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
Patch for landing (9.76 KB, patch)
2012-08-01 21:08 PDT, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Shinya Kawanaka
Comment 1 2012-07-24 23:19:59 PDT
Created attachment 154264 [details] Patch
Shinya Kawanaka
Comment 2 2012-07-25 19:06:21 PDT
Created attachment 154520 [details] Patch
Shinya Kawanaka
Comment 3 2012-07-25 22:36:39 PDT
tkent-san, could you review this?
Kent Tamura
Comment 4 2012-07-25 23:24:49 PDT
Comment on attachment 154520 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=154520&action=review > LayoutTests/fast/forms/input-user-modify.html:34 > +focusAndType("search", "delete"); > +focusAndType("input", "delete"); low test coverage
Shinya Kawanaka
Comment 5 2012-07-30 21:29:43 PDT
Created attachment 155433 [details] Patch
Kent Tamura
Comment 6 2012-07-30 21:40:58 PDT
Comment on attachment 155433 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=155433&action=review > LayoutTests/fast/forms/input-user-modify.html:42 > + <input id="search" type="search"> > + <input id="file" type="file"> > + <input id="range" type="range"> > + <input id="color" type="color"> > + <input id="number" type="number"> > + <input id="placeholder" type="text" placeholder="something"> > + <input id="speech" type="text" x-webkit-speech> We need test cases for <button>, <input type=date>, and <video controls> or <audio controls>. > LayoutTests/fast/forms/input-user-modify.html:45 > +<pre id="console"></pre> This is not used. > LayoutTests/fast/forms/input-user-modify.html:69 > +var successfullyParsed = true; This is unnecessary.
Shinya Kawanaka
Comment 7 2012-07-30 22:04:53 PDT
Created attachment 155437 [details] Patch
Kent Tamura
Comment 8 2012-07-31 06:55:56 PDT
Comment on attachment 155437 [details] Patch ok
WebKit Review Bot
Comment 9 2012-07-31 19:43:20 PDT
Comment on attachment 155437 [details] Patch Rejecting attachment 155437 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: Kit/chromium/third_party/yasm/source/patched-yasm --revision 134927 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 46>At revision 134927. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/13393880
Shinya Kawanaka
Comment 10 2012-07-31 23:30:01 PDT
Created attachment 155728 [details] Patch for landing
WebKit Review Bot
Comment 11 2012-08-01 00:28:03 PDT
Comment on attachment 155728 [details] Patch for landing Rejecting attachment 155728 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: Kit/chromium/third_party/yasm/source/patched-yasm --revision 134927 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 46>At revision 134927. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/13415097
Shinya Kawanaka
Comment 12 2012-08-01 21:08:44 PDT
Created attachment 155967 [details] Patch for landing
WebKit Review Bot
Comment 13 2012-08-01 21:57:42 PDT
Comment on attachment 155967 [details] Patch for landing Clearing flags on attachment: 155967 Committed r124407: <http://trac.webkit.org/changeset/124407>
WebKit Review Bot
Comment 14 2012-08-01 21:57:47 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.