Bug 91677

Summary: REGRESSION (r122660-r122663): mathml/presentation/mo.xhtml, mathml/presentation/row.xhtml failing on Mountain Lion Production Tests
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: Tools / TestsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: dbarton, eric, robert, webkit.review.bot
Priority: P2 Keywords: LayoutTestFailure, MakingBotsRed, Regression
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
URL: http://build.webkit.org/results/Apple%20Lion%20Release%20WK1%20(Tests)/r122663%20(1139)/results.html
Attachments:
Description Flags
mathml/ LayoutTest results
none
Test Case
none
Patch
none
Patch eric: review+, eric: commit-queue+

Jer Noble
Reported 2012-07-18 15:08:31 PDT
mathml/presentation/mo.xhtml and mathml/presentation/row.xhtml started failing on Apple Lion Release WK1 (Tests) between r122661 and r122663 (inclusive). http://trac.webkit.org/log/trunk?rev=122663&stop_rev=122661&limit=4 http://build.webkit.org/results/Apple%20Lion%20Release%20WK1%20(Tests)/r122660%20(1138)/results.html passed http://build.webkit.org/results/Apple%20Lion%20Release%20WK1%20(Tests)/r122663%20(1139)/results.html failed
Attachments
mathml/ LayoutTest results (146.13 KB, application/zip)
2012-07-18 15:30 PDT, Jer Noble 		no flags
Details
Test Case (448 bytes, application/xhtml+xml)
2012-07-18 15:38 PDT, Robert Hogan 		no flags
Details
Patch (130.21 KB, patch)
2012-07-18 15:43 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (220.61 KB, patch)
2012-07-18 15:49 PDT, Jer Noble 		eric: review+
eric: commit-queue+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Robert Hogan
Comment 1 2012-07-18 15:24:35 PDT
The Mac bots don't run pixel tests - would it be possible to see the image diff of these failing tests? (Chromium linux doesn't fully support mathml as far as I can tell).
Jer Noble
Comment 2 2012-07-18 15:27:09 PDT
Sure, let me run one from both revisions.
Jer Noble
Comment 3 2012-07-18 15:30:50 PDT
Created attachment 153107 [details] mathml/ LayoutTest results
Robert Hogan
Comment 4 2012-07-18 15:36:31 PDT
The new layout is closer to Firefox - i.e. the baseline of each green box is near the middle of the parentheses. I think the change in result here is due to the test depending on the old, wrong behaviour of vertical-align with a percentage value.
Robert Hogan
Comment 5 2012-07-18 15:38:08 PDT
Created attachment 153111 [details] Test Case This shows the new behaviour of vertical-align with a negative percentage. WebKit's current rendering of this matches Firefox and Opera, whereas its old rendering does not.
Jer Noble
Comment 6 2012-07-18 15:43:52 PDT
Created attachment 153113 [details] Patch
Robert Hogan
Comment 7 2012-07-18 15:44:10 PDT
Hi Jer, So, I would say it's safe to rebaseline. Don't know if you want anyone else to chime in on it. I'll land the new results tomorrow if no-one objects. Thanks, Robert
Eric Seidel (no email)
Comment 8 2012-07-18 15:47:39 PDT
Comment on attachment 153113 [details] Patch rs=me.
Jer Noble
Comment 9 2012-07-18 15:49:36 PDT
Created attachment 153117 [details] Patch
Eric Seidel (no email)
Comment 10 2012-07-18 15:53:15 PDT
Comment on attachment 153117 [details] Patch rs=me.
Jer Noble
Comment 11 2012-07-18 15:58:54 PDT
Committed r123039: <http://trac.webkit.org/changeset/123039>
Note You need to log in before you can comment on or make changes to this bug.