Bug 90934

Summary: Add dialog element feature toggle to InternalSettings
Product: WebKit Reporter: Matt Falkenhagen <falken>
Component: Tools / TestsAssignee: Matt Falkenhagen <falken>
Status: RESOLVED FIXED    
Severity: Normal CC: morrita, rakuco, tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 84635, 90931    
Attachments:
Description Flags
Patch
none
add to TestExpectations
none
sync none

Matt Falkenhagen
Reported 2012-07-10 21:31:42 PDT
Add dialog element feature toggle to InternalSettings, so layout tests can be written for dialog.
Attachments
Patch (9.92 KB, patch)
2012-07-10 23:01 PDT, Matt Falkenhagen 		no flags
DetailsFormatted DiffDiff
add to TestExpectations (12.72 KB, patch)
2012-07-10 23:44 PDT, Matt Falkenhagen 		no flags
DetailsFormatted DiffDiff
sync (13.69 KB, patch)
2012-07-11 21:43 PDT, Matt Falkenhagen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Matt Falkenhagen
Comment 1 2012-07-10 23:01:58 PDT
Created attachment 151606 [details] Patch
Matt Falkenhagen
Comment 2 2012-07-10 23:16:51 PDT
Comment on attachment 151606 [details] Patch I should update text expectations for each platform since the feature is off at compile-time for all but Chromium. I'll upload a new patch with that.
Matt Falkenhagen
Comment 3 2012-07-10 23:44:05 PDT
Created attachment 151613 [details] add to TestExpectations
Hajime Morrita
Comment 4 2012-07-11 18:49:55 PDT
Comment on attachment 151613 [details] add to TestExpectations Looks good,
WebKit Review Bot
Comment 5 2012-07-11 19:26:11 PDT
Comment on attachment 151613 [details] add to TestExpectations Rejecting attachment 151613 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: m/efl/TestExpectations patching file LayoutTests/platform/gtk/TestExpectations Hunk #1 succeeded at 349 (offset 1 line). patching file LayoutTests/platform/mac/TestExpectations patching file LayoutTests/platform/qt/TestExpectations Hunk #1 succeeded at 110 (offset 1 line). patching file ChangeLog Hunk #1 succeeded at 1 with fuzz 3. Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Hajime Mor..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/13200574
Matt Falkenhagen
Comment 6 2012-07-11 21:43:03 PDT
Created attachment 151853 [details] sync
WebKit Review Bot
Comment 7 2012-07-11 22:33:20 PDT
Comment on attachment 151853 [details] sync Clearing flags on attachment: 151853 Committed r122420: <http://trac.webkit.org/changeset/122420>
WebKit Review Bot
Comment 8 2012-07-11 22:33:31 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.