Bug 90869

Summary: Add ImageDecodeWorker
Product: WebKit Reporter: Kwang Yul Seo <skyul>
Component: ImagesAssignee: Nobody <webkit-unassigned>
Status: RESOLVED WONTFIX    
Severity: Normal CC: dglazkov, dongseong.hwang, gustavo, gyuyoung.kim, levin+threading, philn, rakuco, sw0524.lee, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 90780    
Bug Blocks: 90375, 90935    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch webkit.review.bot: commit-queue-

Kwang Yul Seo
Reported 2012-07-10 04:27:59 PDT
ImageDecodeWorker is a thread pool implementation based on WorkQueue. ImageDecodeWorker internally manages a pool of WorkQueues (n = number of cores) and assigns one from the pool when an ImageDecodeWorker instance is created. So two ImageDecodeWorkers can share one WorkQueue. Parallel image decoders create an instance of ImageDecodeWorker for each image. So the number of ImageDecodeWorker instances can be arbitrarily large, but the number of WorkQueues is limited to the number of cores. This effectively utilizes the underlying cores.
Attachments
Patch (17.45 KB, patch)
2012-07-11 02:21 PDT, Kwonjin Jeong 		no flags
DetailsFormatted DiffDiff
Patch (18.49 KB, patch)
2012-07-11 03:28 PDT, Kwonjin Jeong 		no flags
DetailsFormatted DiffDiff
Patch (18.49 KB, patch)
2012-07-11 03:31 PDT, Kwonjin Jeong 		no flags
DetailsFormatted DiffDiff
Patch (18.58 KB, patch)
2012-07-11 22:15 PDT, Kwonjin Jeong 		no flags
DetailsFormatted DiffDiff
Patch (18.67 KB, patch)
2012-07-11 23:01 PDT, Kwonjin Jeong 		no flags
DetailsFormatted DiffDiff
Patch (18.67 KB, patch)
2012-07-12 00:37 PDT, Kwonjin Jeong 		no flags
DetailsFormatted DiffDiff
Patch (18.20 KB, patch)
2012-07-16 21:51 PDT, Kwonjin Jeong 		webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.
Kwonjin Jeong
Comment 1 2012-07-11 02:21:36 PDT
Created attachment 151656 [details] Patch
Build Bot
Comment 2 2012-07-11 02:30:56 PDT
Comment on attachment 151656 [details] Patch Attachment 151656 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/13204301
Build Bot
Comment 3 2012-07-11 02:44:32 PDT
Comment on attachment 151656 [details] Patch Attachment 151656 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/13207234
Gyuyoung Kim
Comment 4 2012-07-11 02:47:42 PDT
Comment on attachment 151656 [details] Patch Attachment 151656 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/13202279
Kwang Yul Seo
Comment 5 2012-07-11 03:10:55 PDT
Please don't run ews because this patch doesn't build until Bug 90780 is landed.
Early Warning System Bot
Comment 6 2012-07-11 03:27:40 PDT
Comment on attachment 151656 [details] Patch Attachment 151656 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/13199252
Early Warning System Bot
Comment 7 2012-07-11 03:28:38 PDT
Comment on attachment 151656 [details] Patch Attachment 151656 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/13205285
Kwonjin Jeong
Comment 8 2012-07-11 03:28:47 PDT
Created attachment 151666 [details] Patch
Kwonjin Jeong
Comment 9 2012-07-11 03:31:40 PDT
Created attachment 151667 [details] Patch
WebKit Review Bot
Comment 10 2012-07-11 03:36:19 PDT
Comment on attachment 151667 [details] Patch Attachment 151667 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13204311
Build Bot
Comment 11 2012-07-11 03:36:31 PDT
Comment on attachment 151667 [details] Patch Attachment 151667 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/13198317
Gyuyoung Kim
Comment 12 2012-07-11 03:43:43 PDT
Comment on attachment 151667 [details] Patch Attachment 151667 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/13209311
Build Bot
Comment 13 2012-07-11 03:54:07 PDT
Comment on attachment 151667 [details] Patch Attachment 151667 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/13219019
Early Warning System Bot
Comment 14 2012-07-11 04:46:45 PDT
Comment on attachment 151667 [details] Patch Attachment 151667 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/13214021
Early Warning System Bot
Comment 15 2012-07-11 04:50:22 PDT
Comment on attachment 151667 [details] Patch Attachment 151667 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/13206310
Kwonjin Jeong
Comment 16 2012-07-11 22:15:00 PDT
Created attachment 151857 [details] Patch
WebKit Review Bot
Comment 17 2012-07-11 22:21:11 PDT
Comment on attachment 151857 [details] Patch Attachment 151857 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13203593
Build Bot
Comment 18 2012-07-11 22:30:41 PDT
Comment on attachment 151857 [details] Patch Attachment 151857 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/13180691
Early Warning System Bot
Comment 19 2012-07-11 22:34:03 PDT
Comment on attachment 151857 [details] Patch Attachment 151857 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/13207521
Early Warning System Bot
Comment 20 2012-07-11 22:40:08 PDT
Comment on attachment 151857 [details] Patch Attachment 151857 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/13206580
Gyuyoung Kim
Comment 21 2012-07-11 22:47:23 PDT
Comment on attachment 151857 [details] Patch Attachment 151857 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/13198642
Kwonjin Jeong
Comment 22 2012-07-11 23:01:47 PDT
Created attachment 151866 [details] Patch
Kwonjin Jeong
Comment 23 2012-07-12 00:37:35 PDT
Created attachment 151872 [details] Patch
Kwonjin Jeong
Comment 24 2012-07-16 21:51:05 PDT
Created attachment 152695 [details] Patch
Kwang Yul Seo
Comment 25 2012-07-17 18:47:19 PDT
This patch will break cr-linux build because Chromium port does not have WorkQueue implementation.
WebKit Review Bot
Comment 26 2012-07-17 19:06:12 PDT
Comment on attachment 152695 [details] Patch Attachment 152695 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13281359
Gustavo Noronha (kov)
Comment 27 2012-07-17 19:07:31 PDT
Comment on attachment 152695 [details] Patch Attachment 152695 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/13279359
Gyuyoung Kim
Comment 28 2012-07-17 19:07:37 PDT
Comment on attachment 152695 [details] Patch Attachment 152695 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/13272333
Build Bot
Comment 29 2012-07-17 19:25:15 PDT
Comment on attachment 152695 [details] Patch Attachment 152695 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/13276335
Early Warning System Bot
Comment 30 2012-07-17 19:38:59 PDT
Comment on attachment 152695 [details] Patch Attachment 152695 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/13284329
Early Warning System Bot
Comment 31 2012-07-17 19:39:56 PDT
Comment on attachment 152695 [details] Patch Attachment 152695 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/13284330
Build Bot
Comment 32 2012-07-17 23:20:59 PDT
Comment on attachment 152695 [details] Patch Attachment 152695 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/13276385
Kwang Yul Seo
Comment 33 2012-08-06 22:22:19 PDT
We are working on 90869 instead. Close this bug as WONTFIX.
Note You need to log in before you can comment on or make changes to this bug.