Bug 90766

Summary: Register protocol handler files should be in Modules/protocolhandler
Product: WebKit Reporter: Gyuyoung Kim <gyuyoung.kim>
Component: New BugsAssignee: Gyuyoung Kim <gyuyoung.kim>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, morrita, ojan, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 90940    
Attachments:
Description Flags
Patch for EFL ,GTK and QT port
none
Patch
none
Patch none

Gyuyoung Kim
Reported 2012-07-09 02:59:05 PDT
In my humble opinion, NavigatorRegisterProtocolHandler files is able to be moved to Modules. This modules is self-contained. However, I'm not sure whether Bug 82266 should be landed first. If not so, files related to protocol handler should be moved to the modules.
Attachments
Patch for EFL ,GTK and QT port (29.86 KB, patch)
2012-07-09 03:00 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Patch (51.80 KB, patch)
2012-07-09 10:03 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Patch (51.54 KB, patch)
2012-07-12 01:51 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Gyuyoung Kim
Comment 1 2012-07-09 03:00:36 PDT
Created attachment 151220 [details] Patch for EFL ,GTK and QT port
Gyuyoung Kim
Comment 2 2012-07-09 03:01:43 PDT
CC'ing Adam and Hajime.
Build Bot
Comment 3 2012-07-09 03:05:58 PDT
Comment on attachment 151220 [details] Patch for EFL ,GTK and QT port Attachment 151220 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/13167171
WebKit Review Bot
Comment 4 2012-07-09 03:07:38 PDT
Comment on attachment 151220 [details] Patch for EFL ,GTK and QT port Attachment 151220 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13157785
Build Bot
Comment 5 2012-07-09 03:22:00 PDT
Comment on attachment 151220 [details] Patch for EFL ,GTK and QT port Attachment 151220 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/13156885
Adam Barth
Comment 6 2012-07-09 08:57:12 PDT
protocolhandler is listed under "Current Non-Modules Using Module-Related Techniques for Loose Coupling" rather than "Possibly Planned Modules, Based on Previous Emails and the Spreadsheet": http://lists.webkit.org/pipermail/webkit-dev/2012-February/019628.html The conversation progressed somewhat after that email, but that's a reasonably snapshot of our thinking about this topic back in February. Obviously, the things we discussed in that thread aren't set in stone, but you might want to review that thread before working on these sorts of changes. If you think we should do something different than what we discussed then, you might want to start a new thread on webkit-dev about it.
Gyuyoung Kim
Comment 7 2012-07-09 10:03:55 PDT
Created attachment 151264 [details] Patch
Hajime Morrita
Comment 8 2012-07-12 01:11:54 PDT
Comment on attachment 151264 [details] Patch Having the webkit-dev thread http://markmail.org/message/q3hvwjukeachf7sj got no objection, I'd r+ this.
WebKit Review Bot
Comment 9 2012-07-12 01:33:09 PDT
Comment on attachment 151264 [details] Patch Rejecting attachment 151264 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: ndler.cpp rm 'Source/WebCore/page/NavigatorRegisterProtocolHandler.cpp' patching file Source/WebCore/page/NavigatorRegisterProtocolHandler.h rm 'Source/WebCore/page/NavigatorRegisterProtocolHandler.h' patching file Source/WebCore/page/NavigatorRegisterProtocolHandler.idl rm 'Source/WebCore/page/NavigatorRegisterProtocolHandler.idl' Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Hajime Mor..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/13205617
Gyuyoung Kim
Comment 10 2012-07-12 01:51:29 PDT
Created attachment 151886 [details] Patch
WebKit Review Bot
Comment 11 2012-07-12 04:26:44 PDT
Comment on attachment 151886 [details] Patch Clearing flags on attachment: 151886 Committed r122445: <http://trac.webkit.org/changeset/122445>
WebKit Review Bot
Comment 12 2012-07-12 04:26:50 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.