Bug 88859

Summary: XHR_RESPONSE_BLOB is not enabled on some platforms
Product: WebKit Reporter: Mario Sanchez Prada <mario>
Component: WebKit Misc.Assignee: Kinuko Yasuda <kinuko>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, haraken, japhet, jochen, kinuko, ojan, peter, rakuco, svillar, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 89343    
Bug Blocks:    
Attachments:
Description Flags
Patch abarth: review+, webkit.review.bot: commit-queue-

Mario Sanchez Prada
Reported 2012-06-12 04:40:48 PDT
This is making http/tests/xmlhttprequest/response-blob-size.html, introduced in r120042, fail in the following platforms: EFL, GTK, Mac, Qt, Win and WinCairo Skipping the tests for now.
Attachments
Patch (19.43 KB, patch)
2012-06-15 06:24 PDT, Kinuko Yasuda 		abarth: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kinuko Yasuda
Comment 1 2012-06-12 07:59:02 PDT
Actually the current implementation is not platform dependent and probably we could just enable it on all platforms.
Kinuko Yasuda
Comment 2 2012-06-15 06:24:49 PDT
Created attachment 147798 [details] Patch
Adam Barth
Comment 3 2012-06-15 11:05:41 PDT
Comment on attachment 147798 [details] Patch Ok. I presume the spec for this feature is stable. It looks like it's been in the XMLHttpRequest spec for a while.
WebKit Review Bot
Comment 4 2012-06-17 21:49:57 PDT
Comment on attachment 147798 [details] Patch Rejecting attachment 147798 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: sts/platform/gtk/TestExpectations patching file LayoutTests/platform/mac/Skipped Hunk #1 FAILED at 891. 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/mac/Skipped.rej patching file LayoutTests/platform/qt/Skipped patching file LayoutTests/platform/win/Skipped patching file LayoutTests/platform/wincairo/Skipped Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Adam Barth']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/12969631
Peter Beverloo
Comment 5 2012-06-17 21:52:52 PDT
How are the createAsyncFileSystem() in your patch related to this?
Peter Beverloo
Comment 6 2012-06-17 21:54:13 PDT
Sorry, that should read: "How are the changes in your patch touching createAsyncFileSystem() related to this?"
Kinuko Yasuda
Comment 7 2012-06-18 00:07:17 PDT
Committed r120574: <http://trac.webkit.org/changeset/120574>
Note You need to log in before you can comment on or make changes to this bug.