Bug 88161

Summary: [Qt] Remove Qt 4 specific code paths
Product: WebKit Reporter: Simon Hausmann <hausmann>
Component: PlatformAssignee: Simon Hausmann <hausmann>
Status: RESOLVED FIXED    
Severity: Normal CC: bruno.abinader, cmarcelo, eric.carlson, feature-media-reviews, girish, gustavo, kenneth, menard, mifenton, mrobinson, noam, ossy, pnormand, rafael.lobo, vestbo, webkit.review.bot, zoltan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 91730    
Bug Blocks: 60842, 88162    
Attachments:
Description Flags
Patch
none
Patch kenneth: review+

Simon Hausmann
Reported 2012-06-02 00:00:20 PDT
The maintenance of the Qt 4 and Qt 5 code paths in trunk is becoming expensive and we would like to do changes that will be even more difficult to maintain across two major versions, such as the introduction of the QtWebKitWidgets modules. Therefore this bug tracks the removal of the Qt 4 specific code paths in trunk based on the proposal and discussion at http://lists.webkit.org/pipermail/webkit-qt/2012-May/thread.html#2732
Attachments
Patch (214.10 KB, patch)
2012-07-19 06:33 PDT, Simon Hausmann 		no flags
DetailsFormatted DiffDiff
Patch (214.44 KB, patch)
2012-08-02 05:37 PDT, Simon Hausmann 		kenneth: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kenneth Rohde Christiansen
Comment 1 2012-06-02 06:25:29 PDT
Can we now change our signals and slots to the new Qt5 syntax? :-)
Simon Hausmann
Comment 2 2012-06-27 00:36:03 PDT
I'm going to tackle this a bit later, unless somebody beats me to it. Prioritizing the Qt beta and my vacation first :)
Simon Hausmann
Comment 3 2012-07-19 06:33:51 PDT
Created attachment 153244 [details] Patch
Simon Hausmann
Comment 4 2012-07-19 06:34:44 PDT
This patch is not for immediate landing, it will need to be synchronized with updates to build.webkit.org. But let's start here and let the EWS chew on it :)
Early Warning System Bot
Comment 5 2012-07-19 06:46:50 PDT
Comment on attachment 153244 [details] Patch Attachment 153244 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/13270896
Csaba Osztrogonác
Comment 6 2012-07-23 01:56:16 PDT
When will we plan dropping Qt 4 build support for trunk?
Simon Hausmann
Comment 7 2012-07-23 02:00:40 PDT
(In reply to comment #6) > When will we plan dropping Qt 4 build support for trunk? What's a good time for you? Next week? Let's talk on IRC how we could do this with regards to the bots. At the least I guess we have to wait for the test rebasing to finish.
Alexis Menard (darktears)
Comment 8 2012-07-23 04:44:21 PDT
(In reply to comment #7) > (In reply to comment #6) > > When will we plan dropping Qt 4 build support for trunk? > > What's a good time for you? Next week? Let's talk on IRC how we could do this with regards to the bots. > > At the least I guess we have to wait for the test rebasing to finish. And also to stick with a version on Qt5. I really don't have time to take care of the bot every week to update the sha. I'd rather stick with a beta or something like that, with a guarantee that sanity checks were run on Mac OS.
Simon Hausmann
Comment 9 2012-07-23 05:32:41 PDT
(In reply to comment #8) > (In reply to comment #7) > > (In reply to comment #6) > > > When will we plan dropping Qt 4 build support for trunk? > > > > What's a good time for you? Next week? Let's talk on IRC how we could do this with regards to the bots. > > > > At the least I guess we have to wait for the test rebasing to finish. > > And also to stick with a version on Qt5. I really don't have time to take care of the bot every week to update the sha. If maintenance of the mac bot is a time problem, is there somebody else in your team who could help with it?
Alexis Menard (darktears)
Comment 10 2012-07-23 05:41:42 PDT
(In reply to comment #9) > (In reply to comment #8) > > (In reply to comment #7) > > > (In reply to comment #6) > > > > When will we plan dropping Qt 4 build support for trunk? > > > > > > What's a good time for you? Next week? Let's talk on IRC how we could do this with regards to the bots. > > > > > > At the least I guess we have to wait for the test rebasing to finish. > > > > And also to stick with a version on Qt5. I really don't have time to take care of the bot every week to update the sha. > > If maintenance of the mac bot is a time problem, is there somebody else in your team who could help with it? Well it's just that we have a crappy MacBook Pro and it's slow to "try" things.
Simon Hausmann
Comment 11 2012-08-02 05:37:36 PDT
Created attachment 156049 [details] Patch Rebased patch
Kenneth Rohde Christiansen
Comment 12 2012-08-02 09:45:18 PDT
Comment on attachment 156049 [details] Patch r=me, nice stuff
Simon Hausmann
Comment 13 2012-08-07 05:12:53 PDT
Committed r124879: <http://trac.webkit.org/changeset/124879>
Note You need to log in before you can comment on or make changes to this bug.