Bug 88120

Summary:

EventTarget.idl should generate JS bindings

Product:

WebKit

Reporter:

Dominic Cooney <dominicc>

Component:

DOM

Assignee:

Dominic Cooney <dominicc>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, arv, dglazkov, gustavo, haraken, japhet, jochen, ojan, philn, rakuco, vestbo, webkit.review.bot, xan.lopez

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

67312

Attachments:

Description	Flags
WIP Patch	none
WIP Patch	none
WIP Patch	none
Patch	none

Dominic Cooney

Reported 2012-06-01 12:07:39 PDT

For EventTarget to move to the prototype chain and have a constructor (see bug 67312) the JSC binding generation should process EventTarget.idl. Review comments on attachment 110260 [details] suggested making this change separately.

Attachments
WIP Patch (25.90 KB, patch) 2012-06-01 12:13 PDT, Dominic Cooney	no flags	Details Formatted Diff Diff
WIP Patch (28.33 KB, patch) 2012-06-02 10:14 PDT, Dominic Cooney	no flags	Details Formatted Diff Diff
WIP Patch (29.13 KB, patch) 2012-06-03 03:43 PDT, Dominic Cooney	no flags	Details Formatted Diff Diff
Patch (29.41 KB, patch) 2012-06-03 07:46 PDT, Dominic Cooney	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Dominic Cooney

Comment 1 2012-06-01 12:13:39 PDT

Created attachment 145352 [details] WIP Patch

Early Warning System Bot

Comment 2 2012-06-01 12:24:26 PDT

Comment on attachment 145352 [details] WIP Patch Attachment 145352 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/12861718

Early Warning System Bot

Comment 3 2012-06-01 13:24:00 PDT

Comment on attachment 145352 [details] WIP Patch Attachment 145352 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/12861741

Adam Barth

Comment 4 2012-06-01 13:50:47 PDT

Comment on attachment 145352 [details] WIP Patch Looks like you've got some compile trouble on Qt. I'll need to study this patch more closely before r+ing it, but it looks reasonable at first glance.

Gyuyoung Kim

Comment 5 2012-06-01 14:18:30 PDT

Comment on attachment 145352 [details] WIP Patch Attachment 145352 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/12865667

WebKit Review Bot

Comment 6 2012-06-01 16:06:43 PDT

Comment on attachment 145352 [details] WIP Patch Attachment 145352 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12868655

Dominic Cooney

Comment 7 2012-06-01 19:23:08 PDT

Comment on attachment 145352 [details] WIP Patch Looks like this needs more work.

Dominic Cooney

Comment 8 2012-06-02 10:14:50 PDT

Created attachment 145448 [details] WIP Patch To bake on bots.