Bug 87901

Summary: Avoid second layout for flex-direction:row, flex-basis:auto flex items
Product: WebKit Reporter: Ojan Vafai <ojan>
Component: New BugsAssignee: Ojan Vafai <ojan>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, hyatt, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 62048    
Attachments:
Description Flags
Patch tony: review+

Ojan Vafai
Reported 2012-05-30 14:48:05 PDT
Avoid second layout for flex-direction:row, flex-basis:auto flex items
Attachments
Patch (3.08 KB, patch)
2012-05-30 14:49 PDT, Ojan Vafai 		tony: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ojan Vafai
Comment 1 2012-05-30 14:49:06 PDT
Created attachment 144928 [details] Patch
Tony Chang
Comment 2 2012-05-30 15:50:28 PDT
Comment on attachment 144928 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=144928&action=review > Source/WebCore/rendering/RenderFlexibleBox.cpp:997 > + // FIXME: If we're overriding logicalHeight (i.e. hasOrthogonalFlow(child) == true), we only need to layout here if the > + // contents of the child depends on it's height (e.g. % height elements, background-color, etc) because we already > + // layed out once in computeMainAxisPreferredSizes at the unflexed height. Nit: Might be easier to file a bug about this and dump some of this in the bug instead.
Ojan Vafai
Comment 3 2012-05-30 18:37:14 PDT
Committed r119015: <http://trac.webkit.org/changeset/119015>
Note You need to log in before you can comment on or make changes to this bug.