Bug 87343

This might be hard to fix... because of Bug 52195.

*** Bug 106528 has been marked as a duplicate of this bug. ***

When containing ShadowRoot is UserAgentShadowRoot, we should fire selectstart on host element. Otherwise, we should fire selectstart from the target element, I think.

Created attachment 182072 [details] Patch

Comment on attachment 182072 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=182072&action=review Can you explain the reasoning here a bit more? It seems that we shouldn't have such distinctions between UA and author shadow roots. > LayoutTests/fast/dom/shadow/selectstart-expected.txt:1 > +selectstart should be fired in a user selects elements in ShadowDOM, but it should not be propageted to host element. When selecting text in an input element, selectstart should be fired on the input element. propagated.

(In reply to comment #5) > (From update of attachment 182072 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=182072&action=review > > Can you explain the reasoning here a bit more? It seems that we shouldn't have such distinctions between UA and author shadow roots. > > > LayoutTests/fast/dom/shadow/selectstart-expected.txt:1 > > +selectstart should be fired in a user selects elements in ShadowDOM, but it should not be propageted to host element. When selecting text in an input element, selectstart should be fired on the input element. > > propagated. I'll update the ChangeLog soon. But let me summarize my thought here. The main point is that 'selectstart' should be fired when selection started, however it cannot cross the ShadowDOM boundary. Let's consider <input> element. When text is selected, selectstart should be fired. However, on what? If it's fired in inner element of <input>, user cannot detect selectstart is fired. So it should be fired on <input> element itself. But we cannot always fire selectstart event on host element. When we have a content-editable element in Shadow DOM, selecting text on it should fire selectstart on the element itself. So I think we have to distinguish UA ShadowRoot from Author ShadowRoot here. If we have a more good way to do this, please tell me. I didn't come up with one.

Created attachment 182256 [details] Patch

Comment on attachment 182256 [details] Patch Rejecting attachment 182256 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 182256, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: at 1612 (offset 21 lines). Hunk #3 FAILED at 1640. 1 out of 3 hunks FAILED -- saving rejects to file Source/WebCore/editing/FrameSelection.cpp.rej patching file LayoutTests/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file LayoutTests/fast/dom/shadow/selectstart-expected.txt patching file LayoutTests/fast/dom/shadow/selectstart.html Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', 'Ryosuke Niwa']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-commit-queue.appspot.com/results/17631068

selectstart works in v1 implementation. LayoutTests/fast/shadow-dom/trusted-event-scoped-flags.html tests this.