Bug 85904

Summary: REGRESSION(r116440): Broke the Chromium Android bot (Requested by beverloo on #webkit).
Product: WebKit Reporter: WebKit Review Bot <webkit.review.bot>
Component: New BugsAssignee: WebKit Review Bot <webkit.review.bot>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, peter, tony
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 85897    
Attachments:
Description Flags
ROLLOUT of r116440 none

WebKit Review Bot
Reported 2012-05-08 12:08:22 PDT
http://trac.webkit.org/changeset/116440 broke the build: Broke the Chromium Android bot (Requested by beverloo on #webkit). This is an automatic bug report generated by the sheriff-bot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests case pain. "Only you can prevent forest fires." -- Smokey the Bear
Attachments
ROLLOUT of r116440 (1.69 KB, patch)
2012-05-08 12:09 PDT, WebKit Review Bot 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
WebKit Review Bot
Comment 1 2012-05-08 12:09:00 PDT
Created attachment 140760 [details] ROLLOUT of r116440 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment.
Peter Beverloo
Comment 2 2012-05-08 12:12:17 PDT
This has a whole dependency chain of unupstreamed code; changes to ICU are necessary, but these are in a separate repository and then break the build with other errors. This will require some more investigation as to what exactly is necessary to get this working. Previously ICU wasn't build for host, as ImageDiff didn't depend on it. Since this is a Chromium-only binary it may be an option to remove the dependency on WTF altogether; usage seems to be limited. I can take on 85897 early next week. Setting CQ+.
WebKit Review Bot
Comment 3 2012-05-08 12:25:52 PDT
Comment on attachment 140760 [details] ROLLOUT of r116440 Clearing flags on attachment: 140760 Committed r116448: <http://trac.webkit.org/changeset/116448>
WebKit Review Bot
Comment 4 2012-05-08 12:25:57 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.