Bug 85331

Summary: Calendar Picker: Too wide in Japanese locale
Product: WebKit Reporter: Kent Tamura <tkent>
Component: FormsAssignee: Kent Tamura <tkent>
Status: RESOLVED FIXED    
Severity: Normal CC: haraken, keishi, morrita, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 84826    
Bug Blocks: 53961    
Attachments:
Description Flags
Patch
none
Patch 2 none

Kent Tamura
Reported 2012-05-01 18:02:56 PDT
A calendar picker is too wide in Japanese locale because YearMonthController.attachTo() tests "275760年(平成273772年) N月" to decide the width.
Attachments
Patch (3.05 KB, patch)
2012-05-01 18:16 PDT, Kent Tamura 		no flags
DetailsFormatted DiffDiff
Patch 2 (3.07 KB, patch)
2012-05-01 18:29 PDT, Kent Tamura 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kent Tamura
Comment 1 2012-05-01 18:16:06 PDT
Created attachment 139719 [details] Patch
Kentaro Hara
Comment 2 2012-05-01 18:25:15 PDT
Comment on attachment 139719 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=139719&action=review Waiting for keishi-san's review. > Source/WebCore/Resources/calendarPicker.js:139 > + if (year > 2087) Nit: You might want to use imperialEraLimit.
Kent Tamura
Comment 3 2012-05-01 18:26:32 PDT
Comment on attachment 139719 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=139719&action=review >> Source/WebCore/Resources/calendarPicker.js:139 >> + if (year > 2087) > > Nit: You might want to use imperialEraLimit. oh, you're right.
Kent Tamura
Comment 4 2012-05-01 18:29:52 PDT
Created attachment 139720 [details] Patch 2
Keishi Hattori
Comment 5 2012-05-01 19:19:56 PDT
Comment on attachment 139720 [details] Patch 2 ok looks good
WebKit Review Bot
Comment 6 2012-05-01 20:00:46 PDT
Comment on attachment 139720 [details] Patch 2 Clearing flags on attachment: 139720 Committed r115783: <http://trac.webkit.org/changeset/115783>
WebKit Review Bot
Comment 7 2012-05-01 20:00:50 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.