Bug 82213

Summary: Convert RenderSelectionInfo::rect to LayoutUnits
Product: WebKit Reporter: Levi Weintraub <leviw>
Component: Layout and RenderingAssignee: Levi Weintraub <leviw>
Status: RESOLVED FIXED    
Severity: Normal CC: eae, eric, jchaffraix
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 60318    
Attachments:
Description Flags
Patch none

Levi Weintraub
Reported 2012-03-26 08:24:18 PDT
RenderSelectionInfoBase stores a cached repaint rect in local coordinates, and therefor should store it in LayoutUnits.
Attachments
Patch (1.46 KB, patch)
2012-03-26 08:26 PDT, Levi Weintraub 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Levi Weintraub
Comment 1 2012-03-26 08:26:59 PDT
Created attachment 133818 [details] Patch
Eric Seidel (no email)
Comment 2 2012-03-26 15:42:49 PDT
Comment on attachment 133818 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=133818&action=review > Source/WebCore/ChangeLog:9 > + RenderSelectionInfoBase stores a cached repaint rect in local coordinates. Coordinates local to > + renderers should be stored in LayoutUnits. I think these sorts of changelogs might link to the wiki. Ending in "As described in LayoutUnit: http://trac.webkit.org/wiki/LayoutUnit"
Eric Seidel (no email)
Comment 3 2012-03-26 15:43:11 PDT
Comment on attachment 133818 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=133818&action=review >> Source/WebCore/ChangeLog:9 >> + renderers should be stored in LayoutUnits. > > I think these sorts of changelogs might link to the wiki. > > Ending in "As described in LayoutUnit: http://trac.webkit.org/wiki/LayoutUnit" Obviously this means that then the wiki would need to make sure to include this sort of rational. :)
Levi Weintraub
Comment 4 2012-03-27 03:53:03 PDT
Committed r112248: <http://trac.webkit.org/changeset/112248>
Levi Weintraub
Comment 5 2012-03-27 03:54:45 PDT
Comment on attachment 133818 [details] Patch Clearing flags.
Note You need to log in before you can comment on or make changes to this bug.