Bug 80178

Summary: allowDatabaseAccess and databaseExceededQuota should be part of DatabaseContext not ScriptExecutionContext
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, haraken, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 79327    
Attachments:
Description Flags
Patch
none
Patch none

Adam Barth
Reported 2012-03-02 11:56:25 PST
allowDatabaseAccess and databaseExceededQuota should be part of DatabaseContext not ScriptExecutionContext
Attachments
Patch (12.37 KB, patch)
2012-03-02 11:59 PST, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (12.79 KB, patch)
2012-03-02 13:31 PST, Adam Barth 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2012-03-02 11:59:37 PST
Created attachment 129935 [details] Patch
Build Bot
Comment 2 2012-03-02 12:18:04 PST
Comment on attachment 129935 [details] Patch Attachment 129935 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/11799076
Build Bot
Comment 3 2012-03-02 12:20:07 PST
Comment on attachment 129935 [details] Patch Attachment 129935 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/11796111
Early Warning System Bot
Comment 4 2012-03-02 12:34:15 PST
Comment on attachment 129935 [details] Patch Attachment 129935 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/11803071
Adam Barth
Comment 5 2012-03-02 13:31:06 PST
Created attachment 129948 [details] Patch
Eric Seidel (no email)
Comment 6 2012-03-02 13:45:17 PST
Comment on attachment 129948 [details] Patch OK. I assume that Suplement<T> takes care of all the details of making sure that these supelemnts (like DatabaseContext) never outlive their Suplementables?
Adam Barth
Comment 7 2012-03-02 13:46:04 PST
> OK. I assume that Suplement<T> takes care of all the details of making sure that these supelemnts (like DatabaseContext) never outlive their Suplementables? Yes. The Suplement object is owned by the Suplementable object.
WebKit Review Bot
Comment 8 2012-03-02 18:42:32 PST
Comment on attachment 129948 [details] Patch Rejecting attachment 129948 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 Last 500 characters of output: _by_email return self._reviewer_only(self.account_by_email(email)) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/common/config/committers.py", line 632, in account_by_email return self._email_to_account_map().get(email.lower()) if email else None File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/common/config/committers.py", line 525, in _email_to_account_map assert(email not in self._accounts_by_email) # We should never have duplicate emails. AssertionError Full output: http://queues.webkit.org/results/11801210
WebKit Review Bot
Comment 9 2012-03-05 00:14:01 PST
Comment on attachment 129948 [details] Patch Clearing flags on attachment: 129948 Committed r109716: <http://trac.webkit.org/changeset/109716>
WebKit Review Bot
Comment 10 2012-03-05 00:14:12 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.