Bug 80119

Summary: [EFL] Add OwnPtr specialization for Ecore_Timer
Product: WebKit Reporter: YoungTaeck Song <youngtaeck.song>
Component: WebKit EFLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, lucas.de.marchi, rakuco, ryuan.choi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Linux   
Bug Depends on:    
Bug Blocks: 62777    
Attachments:
Description Flags
patch
none
Patch
none
Patch
none
Patch none

YoungTaeck Song
Reported 2012-03-02 00:12:29 PST
Add an overload for deleteOwnedPtr(Ecore_Timer*) on EFL port.
Attachments
patch (1.92 KB, patch)
2012-03-02 00:17 PST, YoungTaeck Song 		no flags
DetailsFormatted DiffDiff
Patch (3.46 KB, patch)
2012-03-04 23:16 PST, YoungTaeck Song 		no flags
DetailsFormatted DiffDiff
Patch (4.20 KB, patch)
2012-03-05 00:33 PST, YoungTaeck Song 		no flags
DetailsFormatted DiffDiff
Patch (2.16 KB, patch)
2012-03-05 17:36 PST, YoungTaeck Song 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
YoungTaeck Song
Comment 1 2012-03-02 00:17:41 PST
Created attachment 129833 [details] patch
Ryuan Choi
Comment 2 2012-03-02 00:21:37 PST
How do you think about applying this in SharedTimerEfl.cpp and somewhere Ecore_Timer is used ?
YoungTaeck Song
Comment 3 2012-03-02 02:23:52 PST
(In reply to comment #2) > How do you think about applying this in SharedTimerEfl.cpp and somewhere Ecore_Timer is used ? This patch for RunLoopEfl.cpp. Please see https://bugs.webkit.org/attachment.cgi?id=129848&action=review. So I think it's not suitable to using SharedTimerEfl.cpp
YoungTaeck Song
Comment 4 2012-03-04 23:16:35 PST
Created attachment 130057 [details] Patch
YoungTaeck Song
Comment 5 2012-03-04 23:22:18 PST
(In reply to comment #2) > How do you think about applying this in SharedTimerEfl.cpp and somewhere Ecore_Timer is used ? Sorry, Ryuan. I misunderstood your intentions. I changed SharedTimerEfl.cpp to use OwnPtr<Ecore_timer> at next patch.
Ryuan Choi
Comment 6 2012-03-04 23:31:28 PST
(In reply to comment #5) > (In reply to comment #2) > > How do you think about applying this in SharedTimerEfl.cpp and somewhere Ecore_Timer is used ? > > Sorry, Ryuan. I misunderstood your intentions. > I changed SharedTimerEfl.cpp to use OwnPtr<Ecore_timer> at next patch. You are missing WebCore's ChangeLog.
YoungTaeck Song
Comment 7 2012-03-05 00:33:04 PST
Created attachment 130066 [details] Patch
Ryuan Choi
Comment 8 2012-03-05 00:36:18 PST
(In reply to comment #7) > Created an attachment (id=130066) [details] > Patch Looks good to me.
Raphael Kubo da Costa (:rakuco)
Comment 9 2012-03-05 10:06:08 PST
Comment on attachment 130066 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=130066&action=review > Source/WebCore/platform/efl/SharedTimerEfl.cpp:41 > -static Ecore_Timer *_sharedTimer = 0; > +static OwnPtr<Ecore_Timer> sharedTimer; Declaring a static object like this makes the code prone to all sorts of problems, since you can't guarantee when this object will be initialized. Either keep the old version, or use the DEFINE_STATIC_LOCAL macro to make sure the object is created on first use.
YoungTaeck Song
Comment 10 2012-03-05 17:36:48 PST
Created attachment 130247 [details] Patch
YoungTaeck Song
Comment 11 2012-03-05 17:38:59 PST
(In reply to comment #9) > (From update of attachment 130066 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=130066&action=review > > > Source/WebCore/platform/efl/SharedTimerEfl.cpp:41 > > -static Ecore_Timer *_sharedTimer = 0; > > +static OwnPtr<Ecore_Timer> sharedTimer; > > Declaring a static object like this makes the code prone to all sorts of problems, since you can't guarantee when this object will be initialized. Either keep the old version, or use the DEFINE_STATIC_LOCAL macro to make sure the object is created on first use. Thanks for your review. We decided to keep the old version.
Raphael Kubo da Costa (:rakuco)
Comment 12 2012-03-05 17:56:04 PST
Comment on attachment 130247 [details] Patch Looks OK to me.
Gyuyoung Kim
Comment 13 2012-03-08 18:15:01 PST
Comment on attachment 130247 [details] Patch LGTM.
WebKit Review Bot
Comment 14 2012-03-15 12:55:57 PDT
Comment on attachment 130247 [details] Patch Clearing flags on attachment: 130247 Committed r110876: <http://trac.webkit.org/changeset/110876>
WebKit Review Bot
Comment 15 2012-03-15 12:56:02 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.