Bug 79568

Summary:

Update Chromium/SVG expectations after the <use> rewrite

Product:

WebKit

Reporter:

Nikolas Zimmermann <zimmermann>

Component:

SVG

Assignee:

Philip Rogers <pdr>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

pdr, schenney, webkit.review.bot, zimmermann

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

78902

Bug Blocks:

Attachments:

Description	Flags
Update tests for svg/W3C-SVG-1.1/animate-elem-80-t-expected.svg	none
Update tests for svg/W3C-SVG-1.1/animate-elem-XX-t.svg	none
Updating so it patches (mid-air collision with my previous patch)	none
More rebaselines -- all the rest should be flaky (will fix in the next, hopefully last, patch)	none
Removed spurious file from previous patch.	none
More updates!	none
Penultimate patch!	webkit.review.bot: commit-queue-
Patchable penultimate patch!	none
Patchable penultimate patch (2)	none
Last expectations update	none

Nikolas Zimmermann

Reported 2012-02-25 02:09:45 PST

Once bug 78902 lands, chromium SVG expectations need a large update.

Attachments
Update tests for svg/W3C-SVG-1.1/animate-elem-80-t-expected.svg (136.38 KB, patch) 2012-04-02 10:57 PDT, Philip Rogers	no flags	Details Formatted Diff Diff
Update tests for svg/W3C-SVG-1.1/animate-elem-XX-t.svg (224.11 KB, patch) 2012-04-02 11:54 PDT, Philip Rogers	no flags	Details Formatted Diff Diff
Updating so it patches (mid-air collision with my previous patch) (224.06 KB, patch) 2012-04-02 12:04 PDT, Philip Rogers	no flags	Details Formatted Diff Diff
More rebaselines -- all the rest should be flaky (will fix in the next, hopefully last, patch) (226.50 KB, patch) 2012-04-02 13:11 PDT, Philip Rogers	no flags	Details Formatted Diff Diff
Removed spurious file from previous patch. (199.93 KB, patch) 2012-04-02 13:18 PDT, Philip Rogers	no flags	Details Formatted Diff Diff
More updates! (326.92 KB, patch) 2012-04-03 08:14 PDT, Philip Rogers	no flags	Details Formatted Diff Diff
Penultimate patch! (386.61 KB, patch) 2012-04-03 13:00 PDT, Philip Rogers	webkit.review.bot: commit-queue-	Details Formatted Diff Diff
Patchable penultimate patch! (383.83 KB, patch) 2012-04-03 13:10 PDT, Philip Rogers	no flags	Details Formatted Diff Diff
Patchable penultimate patch (2) (386.28 KB, patch) 2012-04-03 13:13 PDT, Philip Rogers	no flags	Details Formatted Diff Diff
Last expectations update (253.32 KB, patch) 2012-04-06 08:53 PDT, Philip Rogers	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Stephen Chenney

Comment 1 2012-03-06 07:17:22 PST

Committed r109917: <http://trac.webkit.org/changeset/109917>

Stephen Chenney

Comment 2 2012-03-06 07:17:56 PST

Still have others to update.

Stephen Chenney

Comment 3 2012-03-06 12:30:54 PST

Committed r109951: <http://trac.webkit.org/changeset/109951>

Stephen Chenney

Comment 4 2012-03-06 13:14:30 PST

Some failures made it through the rebaselining.

Stephen Chenney

Comment 5 2012-03-06 13:32:18 PST

Committed r109955: <http://trac.webkit.org/changeset/109955>

Stephen Chenney

Comment 6 2012-03-06 13:32:39 PST

More to come.

Philip Rogers

Comment 7 2012-04-02 10:57:16 PDT

Created attachment 135133 [details] Update tests for svg/W3C-SVG-1.1/animate-elem-80-t-expected.svg

WebKit Review Bot

Comment 8 2012-04-02 11:53:20 PDT

Comment on attachment 135133 [details] Update tests for svg/W3C-SVG-1.1/animate-elem-80-t-expected.svg Clearing flags on attachment: 135133 Committed r112915: <http://trac.webkit.org/changeset/112915>

WebKit Review Bot

Comment 9 2012-04-02 11:53:32 PDT

All reviewed patches have been landed. Closing bug.

Philip Rogers

Comment 10 2012-04-02 11:54:22 PDT

Created attachment 135144 [details] Update tests for svg/W3C-SVG-1.1/animate-elem-XX-t.svg

Philip Rogers

Comment 11 2012-04-02 11:54:59 PDT

Reopening... many more to go!

Philip Rogers

Comment 12 2012-04-02 12:04:49 PDT

Created attachment 135149 [details] Updating so it patches (mid-air collision with my previous patch)

WebKit Review Bot

Comment 13 2012-04-02 12:48:25 PDT

Comment on attachment 135149 [details] Updating so it patches (mid-air collision with my previous patch) Clearing flags on attachment: 135149 Committed r112922: <http://trac.webkit.org/changeset/112922>

WebKit Review Bot

Comment 14 2012-04-02 12:48:31 PDT

All reviewed patches have been landed. Closing bug.

Philip Rogers

Comment 15 2012-04-02 12:49:41 PDT

Reopening... nearing the home stretch!

Philip Rogers

Comment 16 2012-04-02 13:11:36 PDT

Created attachment 135162 [details] More rebaselines -- all the rest should be flaky (will fix in the next, hopefully last, patch)

Philip Rogers

Comment 17 2012-04-02 13:18:17 PDT

Created attachment 135164 [details] Removed spurious file from previous patch.

WebKit Review Bot

Comment 18 2012-04-02 14:34:21 PDT

Comment on attachment 135164 [details] Removed spurious file from previous patch. Clearing flags on attachment: 135164 Committed r112945: <http://trac.webkit.org/changeset/112945>

WebKit Review Bot

Comment 19 2012-04-02 14:34:27 PDT

All reviewed patches have been landed. Closing bug.

Philip Rogers

Comment 20 2012-04-03 08:14:55 PDT

Created attachment 135331 [details] More updates!

Stephen Chenney

Comment 21 2012-04-03 08:22:06 PDT

Comment on attachment 135331 [details] More updates! Clearing flags on attachment: 135331 Committed r113036: <http://trac.webkit.org/changeset/113036>

Stephen Chenney

Comment 22 2012-04-03 08:22:13 PDT

All reviewed patches have been landed. Closing bug.

Philip Rogers

Comment 23 2012-04-03 08:22:37 PDT

Reopening, more to go :)

Philip Rogers

Comment 24 2012-04-03 13:00:23 PDT

Created attachment 135401 [details] Penultimate patch!

WebKit Review Bot

Comment 25 2012-04-03 13:08:58 PDT

Comment on attachment 135401 [details] Penultimate patch! Rejecting attachment 135401 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: tching file LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/struct-use-01-t-expected.txt rm 'LayoutTests/platform/chromium-win/svg/css/group-with-shadow-expected.png' patching file LayoutTests/platform/chromium/test_expectations.txt Hunk #2 FAILED at 1180. 1 out of 2 hunks FAILED -- saving rejects to file LayoutTests/platform/chromium/test_expectations.txt.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/12281073

Philip Rogers

Comment 26 2012-04-03 13:10:31 PDT

Created attachment 135404 [details] Patchable penultimate patch!

Philip Rogers

Comment 27 2012-04-03 13:13:15 PDT

Created attachment 135406 [details] Patchable penultimate patch (2) stretching the definition of penultimate.

WebKit Review Bot

Comment 28 2012-04-03 13:56:41 PDT

Comment on attachment 135406 [details] Patchable penultimate patch (2) Clearing flags on attachment: 135406 Committed r113085: <http://trac.webkit.org/changeset/113085>

WebKit Review Bot

Comment 29 2012-04-03 13:56:49 PDT

All reviewed patches have been landed. Closing bug.

Philip Rogers

Comment 30 2012-04-06 08:53:06 PDT

Created attachment 136029 [details] Last expectations update

Stephen Chenney

Comment 31 2012-04-06 12:16:39 PDT

Comment on attachment 136029 [details] Last expectations update Clearing flags on attachment: 136029 Committed r113477: <http://trac.webkit.org/changeset/113477>

Stephen Chenney

Comment 32 2012-04-06 12:16:47 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.