Bug 78747

Summary: Add zeroLayoutUnit constant.
Product: WebKit Reporter: Levi Weintraub <leviw>
Component: Layout and RenderingAssignee: Levi Weintraub <leviw>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, eae, eric, simon.fraser, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 60318    
Attachments:
Description Flags
Patch none

Levi Weintraub
Reported 2012-02-15 14:47:49 PST
When we switch to subpixel LayoutUnits, we can't use raw integers in places like ternary operations. This patch adds a zeroLayoutUnit constant that can be used instead of raw zeros.
Attachments
Patch (39.96 KB, patch)
2012-02-15 14:59 PST, Levi Weintraub 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Levi Weintraub
Comment 1 2012-02-15 14:59:15 PST
Created attachment 127244 [details] Patch
Eric Seidel (no email)
Comment 2 2012-02-15 15:02:56 PST
Comment on attachment 127244 [details] Patch OK. Seems you added LayoutRect::zero() in another patch. Since this is still a typedef, Ican see how that's impossible here. Is the plan to move to something like that? Doesn't really matter, just curious.
Levi Weintraub
Comment 3 2012-02-15 15:07:07 PST
Comment on attachment 127244 [details] Patch A LayoutRect would be different, but I think you meant LayoutUnit. I think it'd make sense to keep this as a constant. Thanks for the review!
WebKit Review Bot
Comment 4 2012-02-15 20:49:22 PST
Comment on attachment 127244 [details] Patch Clearing flags on attachment: 127244 Committed r107880: <http://trac.webkit.org/changeset/107880>
WebKit Review Bot
Comment 5 2012-02-15 20:49:28 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.