Bug 77758

Summary: Switch geolocation to use Supplemental IDL for Navigator
Product: WebKit Reporter: Mark Pilgrim (Google) <pilgrim>
Component: New BugsAssignee: Mark Pilgrim (Google) <pilgrim>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: abarth, morrita, ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch gyuyoung.kim: commit-queue-

Mark Pilgrim (Google)
Reported 2012-02-03 11:40:38 PST
Switch geolocation to use Supplemental IDL for Navigator
Attachments
Patch (12.39 KB, patch)
2012-02-03 11:43 PST, Mark Pilgrim (Google) 		gyuyoung.kim: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mark Pilgrim (Google)
Comment 1 2012-02-03 11:43:29 PST
Created attachment 125374 [details] Patch
Gyuyoung Kim
Comment 2 2012-02-03 12:32:34 PST
Comment on attachment 125374 [details] Patch Attachment 125374 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/11420419
Adam Barth
Comment 3 2012-02-03 17:18:02 PST
Comment on attachment 125374 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=125374&action=review > Source/WebCore/page/Navigator.h:63 > +#if ENABLE(GEOLOCATION) > + void resetGeolocation(); > + > + Geolocation* geolocation() { return m_geolocation.get(); } > + void setGeolocation(PassRefPtr<Geolocation>); > +#endif Can we move this state out of Navigator somehow? We're not make Navigator.h that much simpler with this change.
Hajime Morrita
Comment 4 2012-02-20 20:24:14 PST
Closing because it looks this patch got robbed by Bug 78860. Feel free to reopen if my understanding wrong. *** This bug has been marked as a duplicate of bug 78860 ***
Note You need to log in before you can comment on or make changes to this bug.