Bug 76579

Summary: createAttributeNS should understand that "xmlns" is allowed in the http://www.w3.org/2000/xmlns/
Product: WebKit Reporter: WebKit Review Bot <webkit.review.bot>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 76143    
Bug Blocks:    
Attachments:
Description Flags
Patch none

WebKit Review Bot
Reported 2012-01-18 15:16:55 PST
AttributeNS should understand that "xmlns" is allowed in the http://www.w3.org/2000/xmlns/ Requested by abarth on #webkit.
Attachments
Patch (8.71 KB, patch)
2012-01-18 22:53 PST, Adam Barth 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2012-01-18 22:53:37 PST
Created attachment 123077 [details] Patch
Eric Seidel (no email)
Comment 2 2012-01-18 23:15:00 PST
Comment on attachment 123077 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=123077&action=review > Source/WebCore/dom/Document.h:862 > + static bool hasValidNamespaceForElements(const QualifiedName&); > + static bool hasValidNamespaceForAttributes(const QualifiedName&); Should we jsut mvoe this onto QualifiedName?
Adam Barth
Comment 3 2012-01-18 23:47:23 PST
> Should we jsut mvoe this onto QualifiedName? Yes. I should also move the prefix character validator code there too.
WebKit Review Bot
Comment 4 2012-01-19 00:31:29 PST
Comment on attachment 123077 [details] Patch Clearing flags on attachment: 123077 Committed r105391: <http://trac.webkit.org/changeset/105391>
WebKit Review Bot
Comment 5 2012-01-19 00:31:33 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.