Bug 76034

Summary: REGRESSION(r101445): [V8] Generated code for custom getters and setters with the [Supplemental] IDL is wrong
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: WebCore JavaScriptAssignee: Kentaro Hara <haraken>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, japhet, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 72138    
Attachments:
Description Flags
Patch none

Kentaro Hara
Reported 2012-01-10 23:41:15 PST
The class name of the implementation of custom getters and setters is wrong. Current V8TestInterface.cpp: // Attribute 'supplementalStr3' (Type: 'attribute' ExtAttr: 'CustomSetter CustomGetter Conditional ImplementedBy') {"supplementalStr3", V8TestSupplemental::supplementalStr3AccessorGetter, V8TestSupplemental::supplementalStr3AccessorSetter, 0 /* no data */, static_cast<v8::AccessControl>(v8::DEFAULT), static_cast<v8::PropertyAttribute>(v8::None), 0 /* on instance */}, Expected V8TestInterface.cpp: // Attribute 'supplementalStr3' (Type: 'attribute' ExtAttr: 'CustomSetter CustomGetter Conditional ImplementedBy') {"supplementalStr3", V8TestInterface::supplementalStr3AccessorGetter, V8TestInterface::supplementalStr3AccessorSetter, 0 /* no data */, static_cast<v8::AccessControl>(v8::DEFAULT), static_cast<v8::PropertyAttribute>(v8::None), 0 /* on instance */},
Attachments
Patch (3.87 KB, patch)
2012-01-10 23:45 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2012-01-10 23:45:24 PST
Created attachment 121984 [details] Patch
Adam Barth
Comment 2 2012-01-10 23:55:34 PST
Comment on attachment 121984 [details] Patch Ah, good point.
Adam Barth
Comment 3 2012-01-10 23:55:45 PST
Sorry I missed that earlier.
WebKit Review Bot
Comment 4 2012-01-11 01:25:13 PST
Comment on attachment 121984 [details] Patch Clearing flags on attachment: 121984 Committed r104684: <http://trac.webkit.org/changeset/104684>
WebKit Review Bot
Comment 5 2012-01-11 01:25:17 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.