Bug 73192

Summary:

Product:

WebKit

Reporter:

Roland Steiner <rolandsteiner>

Component:

CSS

Assignee:

Roland Steiner <rolandsteiner>

Status:

RESOLVED FIXED

Severity:

Enhancement

CC:

dglazkov, dominicc, koivisto, macpherson, menard, morrita, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

73190, 77410, 77525, 77528

Bug Blocks:

49142, 67720

Attachments:

Description	Flags
patch (requires 67790, 73190), with flag	none
patch, updated	none

Roland Steiner

Reported 2011-11-27 23:35:03 PST

Restrict selector matching to only match up to (and including) the scoping element, but not its ancestors.

Attachments
patch (requires 67790, 73190), with flag (23.95 KB, patch) 2011-12-09 00:19 PST, Roland Steiner	no flags	Details Formatted Diff Diff
patch, updated (23.66 KB, patch) 2012-02-01 01:05 PST, Roland Steiner	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Roland Steiner

Comment 1 2011-11-27 23:44:33 PST

Note: Will wait with uploading the patch until 73190 settles.

Roland Steiner

Comment 2 2011-12-09 00:19:51 PST

Created attachment 118541 [details] patch (requires 67790, 73190), with flag

Roland Steiner

Comment 3 2012-01-04 21:18:59 PST

New Year request for review! :)

Roland Steiner

Comment 4 2012-02-01 01:05:16 PST

Created attachment 124899 [details] patch, updated Updated patch after landing basic <style scoped> implementation. Remarks: I'm storing the scope to use in member variables in order to reduce the amount of paramter passing and #ifdef-ing. I'm not sure if I should go further and do this for fastCheckSingleSelector as well (although this would require making that template function a class member) or, conversely, whether it's a good idea in the first place.

Roland Steiner

Comment 5 2012-02-01 01:36:15 PST

Splitting this up into several patches as discussed with Antti on IRC.

Note You need to log in before you can comment on or make changes to this bug.