Bug 73109

Summary: [Refactoring] Remove WebCore.gyp/scripts/rule_binding.py
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: DOMAssignee: Kentaro Hara <haraken>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dominicc, gustavo.noronha, gustavo, japhet, tony, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 72138    
Attachments:
Description Flags
Patch
abarth: review+, gustavo.noronha: commit-queue-
see if gtk looks happy
none
rebased patch for commit none

Kentaro Hara
Reported 2011-11-24 21:58:39 PST
rule_binding.py is used by WebCore.gyp only. rule_binding.py is just a wrapper of generate-bindings.pl and thus we can remove it.
Attachments
Patch (8.67 KB, patch)
2011-11-24 22:04 PST, Kentaro Hara 		abarth: review+
gustavo.noronha: commit-queue-
DetailsFormatted DiffDiff
see if gtk looks happy (8.67 KB, patch)
2011-11-24 23:11 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
rebased patch for commit (8.74 KB, patch)
2011-11-25 00:06 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2011-11-24 22:04:37 PST
Created attachment 116560 [details] Patch
Collabora GTK+ EWS bot
Comment 2 2011-11-24 22:10:58 PST
Comment on attachment 116560 [details] Patch Attachment 116560 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/10640147
Adam Barth
Comment 3 2011-11-24 22:12:46 PST
Comment on attachment 116560 [details] Patch Looks like you might have some trouble with GTK. Sometimes we have these wrappers to deal with windowisms. I don't see any in this file though.
Kentaro Hara
Comment 4 2011-11-24 22:15:00 PST
(In reply to comment #3) > (From update of attachment 116560 [details]) > Looks like you might have some trouble with GTK. Sometimes we have these wrappers to deal with windowisms. I don't see any in this file though. I am investigating it... This is the reason that the WIP patch for bug 72138 is failing on gtk. Thanks.
Kentaro Hara
Comment 5 2011-11-24 23:11:43 PST
Created attachment 116567 [details] see if gtk looks happy
Kentaro Hara
Comment 6 2011-11-25 00:06:59 PST
Created attachment 116573 [details] rebased patch for commit
WebKit Review Bot
Comment 7 2011-11-25 01:31:36 PST
Comment on attachment 116573 [details] rebased patch for commit Clearing flags on attachment: 116573 Committed r101157: <http://trac.webkit.org/changeset/101157>
Kentaro Hara
Comment 8 2011-11-25 01:46:43 PST
FYI: The reason for the gtk failure was as follows: Before: map { $_ =~ s/^\"|\"$//g; "-D$_" } split(' ', $defines) (In this case, "-D$_" can be "-D", which leads to an unexpected command-line flag.) After: map { $_ =~ s/^\"|\"$//g; "-D$_" if $_ } split(' ', $defines)
Note You need to log in before you can comment on or make changes to this bug.